Skip to content

Documentation for usize::wrapping_sub mentions undeclared variable #46308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeehoonkang opened this issue Nov 27, 2017 · 1 comment
Closed

Documentation for usize::wrapping_sub mentions undeclared variable #46308

jeehoonkang opened this issue Nov 27, 2017 · 1 comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@jeehoonkang
Copy link
Contributor

Here, "Computes self - other" should be "Computes self - rhs":

rust/src/libcore/num/mod.rs

Line 644 in dbeb5bf

/// Wrapping (modular) subtraction. Computes `self - other`,

Similarly for many other methods for usize.
@TimNN TimNN added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Nov 28, 2017
@frewsxcv frewsxcv mentioned this issue Dec 3, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Dec 3, 2017
@frewsxcv
Consistent parameter name for numeric ‘checked’ operations.
a2d87d8 
Some checked operations use `rhs` as a parameter name, and some use
`other`. For the sake of consistency, unify everything under the `rhs`
name.

Fixes rust-lang#46308.
@frewsxcv
Copy link
Member

frewsxcv commented Dec 3, 2017

opened a fix for this: https://github.com/rust-lang/rust/pull/46473/files

frewsxcv added a commit to frewsxcv/rust that referenced this issue Dec 3, 2017
@frewsxcv
Rollup merge of rust-lang#46473 - frewsxcv:frewsxcv-param-name, r=TimNN
48d3855 
Consistent parameter name for numeric ‘checked’ operations.

Some checked operations use `rhs` as a parameter name, and some use
`other`. For the sake of consistency, unify everything under the `rhs`
name.

Fixes rust-lang#46308.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frewsxcv @TimNN @jeehoonkang