-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Distinguish between error vs. warning for external macros #57716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
This can be easily added at rust/src/librustc_errors/emitter.rs Lines 850 to 871 in daa53a5
by looking at the |
Centril
added a commit
to Centril/rust
that referenced
this issue
Mar 31, 2019
…ing, r=Centril Distinguish message for external macros depending on error level fixes rust-lang#57716 (I picked you because assigned to this issue.) r? @estebank
Centril
added a commit
to Centril/rust
that referenced
this issue
Mar 31, 2019
…ing, r=Centril Distinguish message for external macros depending on error level fixes rust-lang#57716 (I picked you because assigned to this issue.) r? @estebank
Centril
added a commit
to Centril/rust
that referenced
this issue
Mar 31, 2019
…ing, r=Centril Distinguish message for external macros depending on error level fixes rust-lang#57716 (I picked you because assigned to this issue.) r? @estebank
Centril
added a commit
to Centril/rust
that referenced
this issue
Mar 31, 2019
…ing, r=Centril Distinguish message for external macros depending on error level fixes rust-lang#57716 (I picked you because assigned to this issue.) r? @estebank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
I often see compiler notes for warnings accompanied with this message:
would it be more sensible and correct to say
this _warning_ originates...
?Very superficial but I find seeing "error" in compilation logs catches my eye far too often and
its only a warning. Happy to submit PR if it is a valid change.
The text was updated successfully, but these errors were encountered: