Skip to content

x.py test should be able to test subfolders #60718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
varkor opened this issue May 10, 2019 · 3 comments · Fixed by #60719
Closed

x.py test should be able to test subfolders #60718

varkor opened this issue May 10, 2019 · 3 comments · Fixed by #60719
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@varkor
Copy link
Member

varkor commented May 10, 2019

It would be very useful if ./x.py test src/test/ui/subfolder would run every UI test in src/test/ui/subfolder (at the moment it runs every single UI test). ./x.py test currently works for individual files and for entire test suites, but not directories.
@varkor varkor added the A-testsuite Area: The testsuite used to check the correctness of rustc label May 10, 2019
@varkor
Copy link
Member Author

varkor commented May 10, 2019

The --test-args flag might become obsolete if this becomes possible.

@Centril
Copy link
Contributor

Centril commented May 10, 2019

The --test-args flag might become obsolete if this becomes possible.

Please no... :) --test-args is still useful for testing files that have similar names or if you are just too lazy to give an absolute path.

@Centril Centril added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 10, 2019
@petrochenkov
Copy link
Contributor

petrochenkov commented May 10, 2019 •
edited
Loading

./x.py test currently works for individual files

The most useless feature ever.

Please no... :) --test-args is still useful for testing files that have similar names or if you are just too lazy to give an absolute path.

👍

@varkor varkor mentioned this issue May 10, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue May 14, 2019
@Centril
Rollup merge of rust-lang#60719 - varkor:xpy-test-folder, r=Mark-Simu…
3b4234a 
…lacrum

Allow subdirectories to be tested by x.py test

Fixes rust-lang#60718.

As far as I can tell, multiple `--test-args` flags are ignored (only the first is respected), so if you specify a subdirectory, you won't also be able to filter using `--test-args`. If you don't specify a subdirectory, `--test-args` will continue working as usual, so this is strictly an improvement on the current state of affairs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow subdirectories to be tested by x.py test varkor/rust
3 participants
@Centril @varkor @petrochenkov