Skip to content

x.py fmt silently ignores argument #71094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RalfJung opened this issue Apr 13, 2020 · 0 comments · Fixed by #84783
Closed

x.py fmt silently ignores argument #71094

RalfJung opened this issue Apr 13, 2020 · 0 comments · Fixed by #84783
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@RalfJung
Copy link
Member

Ever since rustfmt was introduced into this repository, I used ./x.py fmt src/librustc_mir and similar commands to format only that part of the tree, thinking that this would cut down formatting time a bit. But I just realized that even when I do ./x.py fmt src/asdfgh, it just formats the entire repository. Looks like the argument is being silently ignored.

Ideally the argument should be honored, but at the least, there should be an error when passing an unexpected argument.

@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Apr 13, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue May 10, 2021
@bors bors closed this as completed in 7e827e9 May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants