Skip to content

name mangling cannot be reversed #7610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thestinger opened this issue Jul 6, 2013 · 13 comments
Closed

name mangling cannot be reversed #7610

thestinger opened this issue Jul 6, 2013 · 13 comments
Labels
A-codegen Area: Code generation P-low Low priority

Comments

@thestinger
Copy link
Contributor

We're using hacks like identity numbers instead of paths to traits and types.

@thestinger
Copy link
Contributor Author

Nominating for the production ready milestone. Debugging and profiling really need to be sane, and these are going to be visible in any traceback.

@brson
Copy link
Contributor

brson commented Jul 8, 2013

Please do not assign issues to milestones. The nomination process is documented here: https://github.com/mozilla/rust/wiki/Note-milestone-nomination

@thestinger
Copy link
Contributor Author

@brson: Ah, I had the wrong impression about how the process worked.

@pnkfelix
Copy link
Member

pnkfelix commented Sep 4, 2013

Visiting for triage, email from 2013-09-02.

I might argue that this should be part of Milestone 4, Well-Covered, before production-ready; Tools (both internal and third-party) to evaluate code quality and code correctness are going to need this.

@alexcrichton
Copy link
Member

Improvement will be made in #8875, although it's mostly fixing bugs there in name collisions, and I think that there's still room for improvement.

@catamorphism
Copy link
Contributor

Accepted for production-ready

@pnkfelix
Copy link
Member

Assiging to 1.0 milestone, since it would be good to have this and it sounds like we might almost already have it. But also giving it priority P-low.

@pnkfelix pnkfelix added this to the 1.0 milestone Mar 20, 2014
@alexcrichton
Copy link
Member

Nominating for removal from a milestone. This is pretty backwards compatible, I think it's safe to have the exact definition of our symbols in flux at 1.0.

@brson brson removed the I-nominated label May 8, 2014
@brson brson removed this from the 1.0 milestone May 8, 2014
@brson
Copy link
Contributor

brson commented May 8, 2014

P-low, not 1.0.

@alexcrichton
Copy link
Member

http://mentorembedded.github.io/cxx-abi/abi.html#mangle.template-param appears to be a good summary of C++ name mangling and how we may be able to leverage the support from C++ for things like generics.

@steveklabnik
Copy link
Member

Triage: no changes here.

@steveklabnik
Copy link
Member

Triage: no change

@bstrie
Copy link
Contributor

bstrie commented Mar 22, 2017

I'm not sure what the complete extent of the scope of this issue was intended to be, but our mangled symbols are indeed reversible (see @alexcrichton 's repo at https://github.com/alexcrichton/rustc-demangle/blob/master/src/lib.rs ). I highly suspect that the exact symbol mangling scheme isn't considered stable though, but I'd consider that to be a distinct issue that we'd need to tackle if we ever wanted to stabilize our ABI.

@bstrie bstrie closed this as completed Mar 22, 2017
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 28, 2021
Add new lint `iter_not_returning_iterator`

Add new lint [`iter_not_returning_iterator`] to detect method `iter()` or `iter_mut()` returning a type not implementing `Iterator`
changelog: Add new lint [`iter_not_returning_iterator`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area: Code generation P-low Low priority
Projects
None yet
Development

No branches or pull requests

7 participants