Skip to content

rust/RELEASES.md doesn't mention that 1.42 allows custom attributes on modules #77098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Emoun opened this issue Sep 23, 2020 · 2 comments · Fixed by #86427
Closed

rust/RELEASES.md doesn't mention that 1.42 allows custom attributes on modules #77098

Emoun opened this issue Sep 23, 2020 · 2 comments · Fixed by #86427
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@Emoun
Copy link

Emoun commented Sep 23, 2020

Pre-1.42, applying an attribute procedural macro to a module was disallowed with the following message:

error[E0658]: custom attributes cannot be applied to modules
...
 = note: for more information, see https://github.com/rust-lang/rust/issues/54727

As an example, see this build using rust 1.34 that exhibits this.

From rust 1.42 and onward this error does not occur, however, this is not detailed in the release notes.
@jonas-schievink jonas-schievink added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Sep 23, 2020
@jyn514 jyn514 added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Sep 23, 2020
@avr1254 avr1254 mentioned this issue Nov 3, 2020
Closed
@bsikar
Copy link

bsikar commented Apr 29, 2021

Does this still need to be done?

@Emoun
Copy link
Author

Emoun commented Apr 29, 2021

I tried looking for update to the release notes that #78690 did but I cannot seem to find it on current master.
Was that PR not merged?

@Rustin170506 Rustin170506 mentioned this issue Jun 18, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jun 21, 2021
@JohnTitor
Rollup merge of rust-lang#86427 - hi-rustin:rustin-patch-release-note…
4a54179 
…, r=Mark-Simulacrum

Updated release note

close rust-lang#77098

base on rust-lang#78690
@bors bors closed this as completed in 13b0f1a Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated release note Rustin170506/rust
Updated release notes. avr1254/rust
4 participants
@jonas-schievink @jyn514 @Emoun @bsikar