RWARC should explicitly 'impl... Clone` #8052
Labels
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Comments
|
It should derive clone, I think. |
|
Even better! |
|
Deriving Clone means losing the docstring. Maybe not a big deal for |
|
Oh, good point, thank you. Yes, they should probably keep the docstrings, even if just to point the reader at the docstring for Arc. |
lilyball
added a commit
to lilyball/rust
that referenced
this issue
Aug 2, 2013
RWArc had a clone() method, but it was part of impl RWArc instead of an implementation of Clone. Stick with the explicit implementation instead of deriving Clone so we can have a docstring. Fixes rust-lang#8052.
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Dec 17, 2021
Because the `if .. {}` statement already puts the condition in
expression scope, contained blocks would be parsed as complete
statements, so any `&` binary expression whose left operand ended in a
block would lead to a non-compiling suggestion.
This adds a visitor to identify such expressions and add parentheses.
This fixes rust-lang#8052.
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Dec 17, 2021
…r=camsteffen
Parenthesize blocks in `needless_bool` suggestion
Because the `if .. {}` statement already puts the condition in expression scope, contained blocks would be parsed as complete
statements, so any `&` binary expression whose left operand ended in a block would lead to a non-compiling suggestion.
We identify such expressions and add parentheses. Note that we don't make a difference between normal and unsafe blocks because the parsing problems are the same for both.
This fixes rust-lang#8052.
---
changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Presently RWARC implements a
clonefunction, but the two wordsClone forare missing, resulting in compiler error when calling clone.The text was updated successfully, but these errors were encountered: