Skip to content

task::rekillable should not be unsafe, and just fail the task, not abort the runtime #8232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bblum opened this issue Aug 2, 2013 · 4 comments
Closed

task::rekillable should not be unsafe, and just fail the task, not abort the runtime #8232

bblum opened this issue Aug 2, 2013 · 4 comments
Labels
A-concurrency Area: Concurrency C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bblum
Copy link
Contributor

bblum commented Aug 2, 2013

No description provided.

@ghost ghost assigned bblum Aug 8, 2013
@flaper87
Copy link
Contributor

If no one is taking care of this, I'd like to take it.

@bblum
Copy link
Contributor Author

bblum commented Aug 17, 2013

@flaper87 go for it; please @bblum me on the pull request

@flaper87 flaper87 mentioned this issue Aug 17, 2013
Closed
@bblum
Copy link
Contributor Author

bblum commented Aug 23, 2013

@flaper87 I am reassigning this bug to you (well, actually, clearing the assignee because github won't let me do that).

@flaper87
Copy link
Contributor

+1 I'll check what's wrong.

bors added a commit that referenced this issue Aug 27, 2013
@bors
auto merge of #8581 : FlaPer87/rust/issue/8232, r=bblum
c822d10 
As for now, rekillable is an unsafe function, instead, it should behave
just like unkillable by encapsulating unsafe code within an unsafe
block.

This patch does that and removes unsafe blocks that were encapsulating
rekillable calls throughout rust's libs.

Fixes #8232
@bors bors closed this as completed in cd92d2c Aug 27, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 24, 2022
@bors
Auto merge of rust-lang#8232 - Jarcho:match_same_arm_860, r=xFrednet
f07ee8a 
`match_same_arms` fix

fixes rust-lang#860
fixes rust-lang#1140

changelog: Don't lint `match_same_arms` when an interposing arm's pattern would overlap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-concurrency Area: Concurrency C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make rekillable consistent with unkillable flaper87/rust
2 participants
@flaper87 @bblum