Skip to content

DoNothing branch of CleanupJob is deadcode #8348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bblum opened this issue Aug 6, 2013 · 1 comment
Closed

DoNothing branch of CleanupJob is deadcode #8348

bblum opened this issue Aug 6, 2013 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bblum
Copy link
Contributor

bblum commented Aug 6, 2013

No description provided.

@toddaaro
Copy link
Contributor

I believe my recent cleanup commit fixed this.

flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 7, 2022
@bors
Auto merge of rust-lang#8588 - pitaj:fix-8348, r=flip1995
41f2ecc 
`indexing_slicing` should not fire if a valid array index comes from a constant function that is evaluated at compile-time

fix rust-lang#8348

changelog: [`indexing_slicing`] fewer false positives in `const` contexts and with `const` indices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toddaaro @bblum