Skip to content

rustdoc: Search results now have lines between them #85654

Closed

Description

@camelid

I'm not certain whether this is a bug or an intentional change, but I couldn't find any PRs that said they were making this change. There were two PRs merged recently that affected the search results display: #85551 and #85568. Cc @GuillaumeGomez.

beta (correct)

image

nightly (incorrect)

image

Activity

  1. added
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    C-bugCategory: This is a bug.
    A-rustdoc-uiArea: Rustdoc UI (generated HTML)
    on May 25, 2021
  2. added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on May 25, 2021
  3. jyn514 commented on May 25, 2021

    @jyn514
    Member

    I like the new version better.

  4. jhpratt commented on May 25, 2021

    @jhpratt
    Member

    This change appears to be intentional, as this line was added to CSS that only applies to this element.

  5. GuillaumeGomez commented on May 25, 2021

    @GuillaumeGomez
    Member

    Yes, it's completely voluntary. We changed the display on mobile and to keep more coherent, we decided to keep the lines too. Closing this issue then. :)

  6. steffahn commented on May 25, 2021

    @steffahn
    Member

    @rustbot label -I-prioritize

  7. removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-uiArea: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions