Skip to content

refactor queries that don't accept inference variables to use canonicalization #86868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nikomatsakis opened this issue Jul 4, 2021 · 5 comments
Open

refactor queries that don't accept inference variables to use canonicalization #86868

nikomatsakis opened this issue Jul 4, 2021 · 5 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jul 4, 2021 •
edited by rustbot
Loading

In #86866 we found various queries that were ICEing when used with inference variables. #86866 worked around these ICEs via simple checks or imprecision, but these queries likely out to be rewritten to use canonicalization or other less hacky techniques.

Discussion with @arora-aman in this Zulip topic, starting about here.
@nikomatsakis nikomatsakis added C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 4, 2021
@nikomatsakis
Copy link
Contributor Author

In the code, some of the places that have to change are marked with FIXME(#86868).

@b-naber
Copy link
Contributor

b-naber commented Jul 5, 2021

I could work on this, or do you want to take this, @arora-aman ?

@jackh726
Copy link
Member

@b-naber I think you should feel free to claim and work on this

@ouz-a
Copy link
Contributor

ouz-a commented Dec 6, 2021

If mentorship is still available I would like to work on this

@vincenzopalazzo
Copy link
Member

@rustbot claim

@lcnr lcnr added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nikomatsakis @vincenzopalazzo @lcnr @jackh726 @b-naber @ouz-a