Skip to content

Rust triggers LLVM ARM backend bug #9117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sanxiyn opened this issue Sep 11, 2013 · 2 comments
Closed

Rust triggers LLVM ARM backend bug #9117

sanxiyn opened this issue Sep 11, 2013 · 2 comments
Assignees
@alexcrichton
Labels
O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state

Comments

@sanxiyn
Copy link
Member

sanxiyn commented Sep 11, 2013

Rust triggers LLVM bug 17180. I haven't figured out the exact condition yet, but using LLVM's integrated assembler is required, so this started to happen only when we switched to LLVM's integrated assembler from Android NDK's external assembler(#8931).

The bug is fixed upstream in r190417. Should I upgrade to the latest LLVM, or just cherry-pick the fix? The fix is trivial, so cherry-picking is not hard. @alexcrichton?
@ghost ghost assigned alexcrichton Sep 11, 2013
@alexcrichton
Copy link
Member

Let's cherry-pick it for now. Assigning myself.

@alexcrichton
Copy link
Member

For posterity, the cherry-pick doesn't cleanly apply, so @sanxiyn is going to resolve the conflicts and rebase it on our current llvm patch and I'll send a pull to integrate it.

@sanxiyn sanxiyn mentioned this issue Sep 16, 2013
Merged
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 18, 2022
@bors
Auto merge of rust-lang#9117 - Jarcho:unsafe_block_closure, r=giraffate
48e527e 
Fix `undocumented_unsafe_blocks` in closures

fixes rust-lang#9114
changelog: Fix `undocumented_unsafe_blocks` not checking for comments before the start of a closure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcrichton alexcrichton

Labels
O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanxiyn @alexcrichton