Skip to content

rustpkg man page is a bit misleading #9221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
catamorphism opened this issue Sep 16, 2013 · 0 comments
Closed

rustpkg man page is a bit misleading #9221

catamorphism opened this issue Sep 16, 2013 · 0 comments

Comments

@catamorphism
Copy link
Contributor

The rustpkg man page (which I didn't know existed until now) is slightly misleading in a few places -- for example, it mentions git:// URLs, which aren't supported yet. The man page should either note features that are not implemented yet, or else not mention those features at all and refer to rustpkg.md for future plans.

bors added a commit that referenced this issue Sep 17, 2013
Closes #9221.

"rustpkg test" isn't implemented yet, so it shouldn't be in the manpage. Referring interested parties to the manual is probably
the right thing for now; eventually, these documents should merge.

/cc @catamorphism
@bors bors closed this as completed in e1507f3 Sep 17, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 21, 2022
…flip1995

Improvement for  `equatable_if_let`

fixes rust-lang#9221

This PR makes sure that enums or structs not implementing `PartialEq` trait but still using the `if let` patterns can be linted to be rewritten with `matches!`.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

- \[ ] Followed [lint naming conventions][lint_naming]
- \[x] Added passing UI tests (including committed `.stderr` file)
- \[x] `cargo test` passes locally
- \[ ] Executed `cargo dev update_lints`
- \[ ] Added lint documentation
- \[x] Run `cargo dev fmt`

---

changelog: Improve [`equatable_if_let`] with additional `matches!` suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant