Skip to content

EOL workaround for Windows is incorrect, mangles binary files (the icon) #9421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thestinger opened this issue Sep 23, 2013 · 1 comment
Closed

EOL workaround for Windows is incorrect, mangles binary files (the icon) #9421

thestinger opened this issue Sep 23, 2013 · 1 comment

Comments

@thestinger
Copy link
Contributor

62991e6 added eol=lf to the * glob in .gitattributes, which is right for text files but not binary ones. I already set text back to text=auto (SHA: 9e3258e) but that doesn't appear to be enough.
@huonw
Copy link
Member

huonw commented Feb 23, 2014

ee74ccb added special handling for the logo, closing.

@huonw huonw closed this as completed Feb 23, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 9, 2022
@bors
Auto merge of rust-lang#9421 - xphoniex:fix-rust-lang#9420, r=giraffate
7babd1b 
Suggest `unwrap_or_default` when closure returns `"".to_string`

Closes rust-lang/rust-clippy#9420

changelog: [`unwrap_or_else_default`]: suggest `unwrap_or_default()` instead of `unwrap_or_else` with a closure that returns an empty `to_string`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huonw @thestinger