Changing file on latest rustdoc has text slide for 1s

[Ten0]

Reproduction

Load https://doc.rust-lang.org/stable/src/core/alloc/layout.rs.html#436
Open files panel on the left.
Refresh page.

You'll notice everytime you load the page, the file list slides again. So we now have to wait 1s for it to stop sliding before starting to read the file we clicked on.

Note

Btw, I'd rather this never slides at all. This is time loss anyway. Could there be an option to disable this?

[GuillaumeGomez]

So there are two different things here apparently:

• removing the animation
• Don't remember the file sidebar state

Did I get it right?

[Ten0]

Yes absolutely 🙂🙏

A single simple solution to both "things" could be to completely remove the animation.
I don't know of any IDE that does this - probably because it isn't optimal with regards to ergonomics.
The fact the new panel now slides the code so we can read the code and have the panel open at the same time is still an improvement over the previous panel, even if we revert the animation part.

[GuillaumeGomez]

I think the idea behind the animation is to allow the reader to see that it's not hovering the code. As for the setting, not sure.

What do you think @jsha?

[jsha]

I agree with @Ten0, we should remove the animation. It bothers me as well, I just haven't found the time to file an issue / PR about it. :-) I don't think we should add a setting.

[GuillaumeGomez]

Ok, I'll remove the animation then. Will send a PR tomorrow. For the setting, it's that we keep the current save the state of the sidebar. Should I remove it as well?

[Ten0]

For the setting, it's that we keep the current save the state of the sidebar. Should I remove it as well?

My idea of new setting was rather "should there be an animation or should it be static", if we didn't want to remove the animation completely, for those of us that don't think the animation is worth the wait (so no need for a such new setting if we just remove the animation completely :) )

With regards to the other setting idea you seem to be talking about, it seems reasonable to me to always keep the current state of the sidebar, as we currently do, and not add an extra setting for that either :)

[GuillaumeGomez]

Oh ok. Well, that cleared things up. I'll just remove the animation then.