-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Regression with lifetimes when using Foo as Trait
and Trait
has an associated lifetime
#99949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
P-critical
Critical priority
regression-from-stable-to-nightly
Performance or correctness regression from stable to nightly.
Comments
ping @cjgillot since you're the author of the commit |
WG-prioritization assigning priority (Zulip discussion). @rustbot label -I-prioritize +P-critical |
note: there's a fix in #99953 ready for review |
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this issue
Apr 20, 2024
Always create elided lifetimes, even if inferred. `PathSource` gives the context in which a path is encountered. The same `PathSource` is used for the full path and the `QSelf` part. Therefore, we can only rely on `PathSource` to know whether typechecking will be able to infer the lifetimes, not whether we need to insert them at all. Fixes rust-lang/rust#99949
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this issue
Apr 27, 2024
Always create elided lifetimes, even if inferred. `PathSource` gives the context in which a path is encountered. The same `PathSource` is used for the full path and the `QSelf` part. Therefore, we can only rely on `PathSource` to know whether typechecking will be able to infer the lifetimes, not whether we need to insert them at all. Fixes rust-lang/rust#99949
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P-critical
Critical priority
regression-from-stable-to-nightly
Performance or correctness regression from stable to nightly.
This code:
compiles on stable but not on nightly.
Error:
I bisected it to 2643b16 and then refined it; reverting
a2254d5 fixes the issue.
This is the cause for launchbadge/sqlx#2004
The text was updated successfully, but these errors were encountered: