Prevent ICE for doc_alias on match arm, statement, expression#100029
Merged
bors merged 5 commits intorust-lang:masterfrom Aug 4, 2022
Merged
Prevent ICE for doc_alias on match arm, statement, expression#100029bors merged 5 commits intorust-lang:masterfrom
doc_alias on match arm, statement, expression#100029bors merged 5 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
cjgillot
reviewed
Aug 1, 2022
Contributor
Author
|
The force-push was because I forgot to fix formatting. Whoops |
This comment has been minimized.
This comment has been minimized.
- Added `Impl`, `Closure`, ForeignMod` targets - `Target::name` changed for `Target::Impl` - Error output for `Target::ForeignMod` changed to "foreign module"
Contributor
Author
|
Thanks for all the help! Hopefully these changes wrap it up |
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#98771 (Add support for link-flavor rust-lld for iOS, tvOS and watchOS) - rust-lang#98835 (relate `closure_substs.parent_substs()` to parent fn in NLL) - rust-lang#99746 (Use `TraitEngine` in more places that don't specifically need `FulfillmentContext::new_in_snapshot`) - rust-lang#99786 (Recover from C++ style `enum struct`) - rust-lang#99795 (Delay a bug when failed to normalize trait ref during specialization) - rust-lang#100029 (Prevent ICE for `doc_alias` on match arm, statement, expression) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99777.
This is a pretty minimal fix that should be safe, since rustdoc doesn't generate documentation for match arms, statements, or expressions. I mentioned in the linked issue that the
doc_aliastarget checking should probably be improved to avoid future ICEs, but as a new contributor, I'm not confident enough with the HIR types to make a larger change.