Skip to content

update Miri #100841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2022
Merged

update Miri #100841

merged 1 commit into from
Aug 21, 2022

Conversation

RalfJung
Copy link
Member

Fixes #100779

@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2022

The Miri submodule was changed

cc @rust-lang/miri

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2022
@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Aug 21, 2022

📌 Commit 4df65c3 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2022
@bors
Copy link
Collaborator

bors commented Aug 21, 2022

⌛ Testing commit 4df65c3 with merge 3130203...

@bors
Copy link
Collaborator

bors commented Aug 21, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 3130203 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2022
@bors bors merged commit 3130203 into rust-lang:master Aug 21, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 21, 2022
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #100841!

Tested on commit 3130203.
Direct link to PR: #100841

🎉 miri on windows: test-fail → test-pass (cc @RalfJung @oli-obk).
🎉 miri on linux: test-fail → test-pass (cc @RalfJung @oli-obk).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 21, 2022
Tested on commit rust-lang/rust@3130203.
Direct link to PR: <rust-lang/rust#100841>

🎉 miri on windows: test-fail → test-pass (cc @RalfJung @oli-obk).
🎉 miri on linux: test-fail → test-pass (cc @RalfJung @oli-obk).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3130203): comparison url.

Instruction count

  • Primary benchmarks: mixed results
  • Secondary benchmarks: ❌ relevant regression found
mean1 max count2
Regressions ❌
(primary)
0.8% 1.0% 5
Regressions ❌
(secondary)
0.2% 0.2% 1
Improvements ✅
(primary)
-0.8% -0.8% 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.5% 1.0% 6

Max RSS (memory usage)

Results
  • Primary benchmarks: ❌ relevant regression found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions ❌
(primary)
2.5% 2.5% 1
Regressions ❌
(secondary)
2.3% 3.4% 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% -2.9% 1
All ❌✅ (primary) 2.5% 2.5% 1

Cycles

Results
  • Primary benchmarks: ❌ relevant regression found
  • Secondary benchmarks: ❌ relevant regressions found
mean1 max count2
Regressions ❌
(primary)
1.9% 1.9% 1
Regressions ❌
(secondary)
4.7% 4.9% 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.9% 1.9% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@rustbot rustbot added the perf-regression Performance regression. label Aug 21, 2022
@RalfJung RalfJung deleted the miri branch August 21, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#100740
6 participants