Skip to content

Fix compile errors for uwp-windows-msvc targets #101481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2022
Merged

Fix compile errors for uwp-windows-msvc targets #101481

merged 1 commit into from
Sep 7, 2022

Conversation

ChrisDenton
Copy link
Member

Fixes #101480

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 6, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

@ChrisDenton: no appropriate reviewer found, use r? to override

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2022
@ChrisDenton
Copy link
Member Author

r? libs

@ChrisDenton
Copy link
Member Author

There are actually two small issues here but one of them is fixed in another PR so I'll only focus on the other one to avoid merge conflicts.

@thomcc
Copy link
Member

thomcc commented Sep 6, 2022

Oof!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 6, 2022

📌 Commit 774e712 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2022
@thomcc thomcc mentioned this pull request Sep 6, 2022
Merged
@JohnTitor JohnTitor mentioned this pull request Sep 6, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2022
@bors
Auto merge of rust-lang#101508 - JohnTitor:rollup-i5i2vqc, r=JohnTitor
8c41305 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#101451 (Add incremental test for changing struct name in assoc type.)
 - rust-lang#101468 (fix RPIT ICE for implicit HRTB when missing dyn)
 - rust-lang#101481 (Fix compile errors for uwp-windows-msvc targets)
 - rust-lang#101484 (Remove dead broken code from const zst handling in backends)
 - rust-lang#101486 (Add list of recognized repr attributes to the unrecognized repr error)
 - rust-lang#101488 (rustdoc: remove unused CSS `#results > table`)
 - rust-lang#101491 (rustdoc: remove outdated CSS `.sub-variant > div > .item-info`)
 - rust-lang#101497 (:arrow_up: rust-analyzer)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 923dae5 into rust-lang:master Sep 7, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 7, 2022
@ChrisDenton ChrisDenton deleted the uwp-fix branch March 9, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

std library compile errors for uwp-windows-msvc targets
5 participants
@ChrisDenton @rustbot @rust-highfive @thomcc @bors