remove type traversal for mir constants #102355

lcnr · 2022-09-27T10:01:12Z

r? @oli-obk cc @b-naber

lcnr · 2022-09-27T10:04:20Z

@bors try @rust-timer queue

rust-timer · 2022-09-27T10:04:22Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-09-27T10:04:28Z

⌛ Trying commit 3bf096e910e5505ac5ce5b763eed6a3e300f172b with merge c3a65989026d958631c9a396441824adfc0636a2...

bors · 2022-09-27T11:34:49Z

☀️ Try build successful - checks-actions
Build commit: c3a65989026d958631c9a396441824adfc0636a2 (c3a65989026d958631c9a396441824adfc0636a2)

rust-timer · 2022-09-27T11:34:50Z

Queued c3a65989026d958631c9a396441824adfc0636a2 with parent de0b511, future comparison URL.

rust-timer · 2022-09-27T13:19:19Z

Finished benchmarking commit (c3a65989026d958631c9a396441824adfc0636a2): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.7%	[0.6%, 0.8%]	7
Regressions ❌ (secondary)	1.2%	[1.0%, 1.5%]	6
Improvements ✅ (primary)	-0.4%	[-0.6%, -0.2%]	17
Improvements ✅ (secondary)	-2.0%	[-3.5%, -0.5%]	13
All ❌✅ (primary)	-0.1%	[-0.6%, 0.8%]	24

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[1.7%, 4.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-4.8%, -3.1%]	2
All ❌✅ (primary)	-	-	0

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

lcnr · 2022-09-29T10:44:24Z

@bors try @rust-timer queue

rust-timer · 2022-09-29T10:44:26Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-09-29T10:44:40Z

⌛ Trying commit fc8924e274e4e5d667cce6e1520f7029e8f32100 with merge dbe57d7137cfc934695ee70d1a8f8196a646d707...

bors · 2022-09-29T12:23:56Z

☀️ Try build successful - checks-actions
Build commit: dbe57d7137cfc934695ee70d1a8f8196a646d707 (dbe57d7137cfc934695ee70d1a8f8196a646d707)

rust-timer · 2022-09-29T12:23:57Z

Queued dbe57d7137cfc934695ee70d1a8f8196a646d707 with parent 8a497b7, future comparison URL.

rust-timer · 2022-09-29T13:58:16Z

Finished benchmarking commit (dbe57d7137cfc934695ee70d1a8f8196a646d707): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.7%	[0.6%, 0.9%]	6
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.7%, -0.2%]	14
Improvements ✅ (secondary)	-1.5%	[-2.1%, -0.4%]	18
All ❌✅ (primary)	-0.1%	[-0.7%, 0.9%]	20

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[3.5%, 4.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.7%	[-2.4%, -0.9%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	3.7%	[3.7%, 3.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-6.5%	[-6.5%, -6.5%]	1
Improvements ✅ (secondary)	-3.3%	[-4.1%, -2.6%]	2
All ❌✅ (primary)	-1.4%	[-6.5%, 3.7%]	2

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

rust-timer · 2022-10-06T16:31:35Z

Finished benchmarking commit (55e7418fe84f5fefb4ce380bcb4f6d4066a69d68): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.7%	[0.6%, 0.9%]	6
Regressions ❌ (secondary)	0.7%	[0.5%, 0.9%]	6
Improvements ✅ (primary)	-0.5%	[-1.4%, -0.3%]	15
Improvements ✅ (secondary)	-1.9%	[-3.8%, -0.3%]	16
All ❌✅ (primary)	-0.2%	[-1.4%, 0.9%]	21

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.7%	[1.2%, 2.2%]	2
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.6%	[-1.6%, -1.6%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

lcnr · 2022-10-17T10:01:53Z

@bors try @rust-timer queue

rust-timer · 2022-10-17T10:01:55Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-10-17T10:02:02Z

⌛ Trying commit d04bff6 with merge b26fc916212a48c91195f77cb3e4d654b68b4186...

bors · 2022-10-17T12:02:06Z

☀️ Try build successful - checks-actions
Build commit: b26fc916212a48c91195f77cb3e4d654b68b4186 (b26fc916212a48c91195f77cb3e4d654b68b4186)

rust-timer · 2022-10-17T12:02:08Z

Queued b26fc916212a48c91195f77cb3e4d654b68b4186 with parent 1536ab1, future comparison URL.

rust-timer · 2022-10-17T13:36:41Z

Finished benchmarking commit (b26fc916212a48c91195f77cb3e4d654b68b4186): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	41
Improvements ✅ (secondary)	-1.4%	[-3.7%, -0.2%]	37
All ❌✅ (primary)	-0.4%	[-0.8%, -0.2%]	41

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-4.1%, -2.0%]	9
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

lcnr · 2022-10-17T13:56:55Z

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

perf seems to be good now xx

@bors r=oli-obk

bors · 2022-10-17T13:56:57Z

📌 Commit d04bff6 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2022-10-17T14:19:31Z

⌛ Testing commit d04bff6 with merge a9d1caf...

bors · 2022-10-17T17:05:10Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing a9d1caf to master...

rust-timer · 2022-10-17T18:22:12Z

Finished benchmarking commit (a9d1caf): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.2%]	36
Improvements ✅ (secondary)	-1.3%	[-3.7%, -0.2%]	37
All ❌✅ (primary)	-0.4%	[-0.8%, -0.2%]	36

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-6.9%, -2.1%]	17
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[2.0%, 2.0%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

…smaller, r=lcnr Remove `NormalizationError::ConstantKind` No longer in use by `TryNormalizeAfterErasingRegionsFolder` (as of rust-lang#102355 / e8150fa it seems). It's making `LayoutError`, etc. kinda large -- that was noticed by `@zoxc.`

rust-highfive assigned oli-obk Sep 27, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 27, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 27, 2022

oli-obk approved these changes Sep 27, 2022

View reviewed changes

lcnr added the A-const-generics Area: const generics (parameters and arguments) label Sep 27, 2022

lcnr changed the title ~~removal type traversal for mir constants~~ remove type traversal for mir constants Sep 27, 2022

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 27, 2022

lcnr force-pushed the bye-bye-type-traversal branch from 3bf096e to fc8924e Compare September 29, 2022 10:42

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 29, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 29, 2022

lcnr force-pushed the bye-bye-type-traversal branch from 0328340 to 83792f6 Compare October 5, 2022 16:25

lcnr closed this Oct 5, 2022

lcnr reopened this Oct 5, 2022

lcnr force-pushed the bye-bye-type-traversal branch from 83792f6 to 5906b39 Compare October 5, 2022 16:26

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 6, 2022

lcnr added 3 commits October 17, 2022 10:54

mir constants: type traversing bye bye

e8150fa

rm try_normalize_mir_const_after_erasing_regions

face090

add inline to TrivialTypeTraversalImpls

d04bff6

lcnr force-pushed the bye-bye-type-traversal branch from dd3e2aa to d04bff6 Compare October 17, 2022 10:01

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 17, 2022

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Oct 17, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 17, 2022

bors merged commit a9d1caf into rust-lang:master Oct 17, 2022

rustbot added this to the 1.66.0 milestone Oct 17, 2022

lcnr deleted the bye-bye-type-traversal branch October 18, 2022 07:08

compiler-errors mentioned this pull request Mar 3, 2023

Remove NormalizationError::ConstantKind #108689

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove type traversal for mir constants #102355

remove type traversal for mir constants #102355

lcnr commented Sep 27, 2022

lcnr commented Sep 27, 2022

rust-timer commented Sep 27, 2022

bors commented Sep 27, 2022

bors commented Sep 27, 2022

rust-timer commented Sep 27, 2022

rust-timer commented Sep 27, 2022

lcnr commented Sep 29, 2022

rust-timer commented Sep 29, 2022

bors commented Sep 29, 2022

bors commented Sep 29, 2022

rust-timer commented Sep 29, 2022

rust-timer commented Sep 29, 2022

rust-timer commented Oct 6, 2022

lcnr commented Oct 17, 2022

rust-timer commented Oct 17, 2022

bors commented Oct 17, 2022

bors commented Oct 17, 2022

rust-timer commented Oct 17, 2022

rust-timer commented Oct 17, 2022

lcnr commented Oct 17, 2022

bors commented Oct 17, 2022

bors commented Oct 17, 2022

bors commented Oct 17, 2022

rust-timer commented Oct 17, 2022

remove type traversal for mir constants #102355

remove type traversal for mir constants #102355

Conversation

lcnr commented Sep 27, 2022

lcnr commented Sep 27, 2022

rust-timer commented Sep 27, 2022

bors commented Sep 27, 2022

bors commented Sep 27, 2022

rust-timer commented Sep 27, 2022

rust-timer commented Sep 27, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Footnotes

lcnr commented Sep 29, 2022

rust-timer commented Sep 29, 2022

bors commented Sep 29, 2022

bors commented Sep 29, 2022

rust-timer commented Sep 29, 2022

rust-timer commented Sep 29, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Footnotes

rust-timer commented Oct 6, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Footnotes

lcnr commented Oct 17, 2022

rust-timer commented Oct 17, 2022

bors commented Oct 17, 2022

bors commented Oct 17, 2022

rust-timer commented Oct 17, 2022

rust-timer commented Oct 17, 2022

Overall result: ✅ improvements - no action needed

Footnotes

lcnr commented Oct 17, 2022

bors commented Oct 17, 2022

bors commented Oct 17, 2022

bors commented Oct 17, 2022

rust-timer commented Oct 17, 2022

Overall result: ✅ improvements - no action needed

Footnotes