use a single test task when valgrinding #1921 #10250
Conversation
|
r? @brson |
| _ => fail!("RUST_TEST_TASKS is `{}`, should be a positive integer.", s) | ||
| if running_on_valgrind() { | ||
| 1 | ||
| } |
There was a problem hiding this comment.
The convention is for this to be formattted like
1
} else {
match ...with the else and the braces all on one line.
| _ => fail!("RUST_TEST_TASKS is `{}`, should be a positive integer.", s) | ||
| if running_on_valgrind() { | ||
| 1 | ||
| } else{ |
|
rebased! |
|
r? @brson |
|
Oh, no. I've realized this may not be the right way to make this fix. This performance problem is only an issue for those tests that are not run by our compiletest driver - if we make the fix this way then it will probably speed up execution of our normal integrated test drivers, but vastly slow down the execution of the compiler tests (src/run-pass, compile-fail, etc.). I wonder how worthwhile it is to do this. @reedlepee123 can you measure the difference in time it takes to run |
|
Closing for lack of activity. @reedlepee123 , feel free to re-open it if you work on it more! |
wildcard_enum_match_arm lint takes the enum origin into account fixes rust-lang#7419 --- changelog: Enhancement: [`wildcard_enum_match_arm`]: Now lints missing private variants, for local enums [rust-lang#10250](rust-lang/rust-clippy#10250) <!-- changelog_checked -->
No description provided.