Move implementation for threads to Rust #10290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| unsafe { | ||
| let ptr: LPVOID = cast::transmute(tramp); | ||
| let routine: LPTHREAD_START_ROUTINE = cast::transmute(thread_start); | ||
| CreateThread(ptr::null(), 1024*1024, routine, tramp, 0, ptr::null()) |
There was a problem hiding this comment.
Should this constant be a static somewhere? (DEFAULT_THREAD_STACK_SIZE or something?)
There was a problem hiding this comment.
Yeah, good point, what is exactly the convention here?
This binds to the appropriate pthreads_* and Windows specific functions and calls them from Rust. This allows for removal of the C++ support code for threads. Fixes #10162
bors
added a commit
that referenced
this pull request
Nov 5, 2013
This binds to the appropriate pthreads_* and Windows specific functions and calls them from Rust. This allows for removal of the C++ support code for threads. This needs to be reviewed for the Windows parts, I've tested on OS X and Linux. Fixes #10162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This binds to the appropriate pthreads_* and Windows specific functions
and calls them from Rust. This allows for removal of the C++ support
code for threads.
This needs to be reviewed for the Windows parts, I've tested on OS X and Linux.
Fixes #10162