-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustdoc: remove unused .sub-logo-container
DOM on non-source pages
#103129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors
merged 2 commits into
rust-lang:master
from
notriddle:notriddle/sub-logo-container
Oct 17, 2022
Merged
rustdoc: remove unused .sub-logo-container
DOM on non-source pages
#103129
bors
merged 2 commits into
rust-lang:master
from
notriddle:notriddle/sub-logo-container
Oct 17, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon. Please see the contribution instructions for more information. |
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
This comment has been minimized.
This comment has been minimized.
1028753
to
7de1b37
Compare
This comment has been minimized.
This comment has been minimized.
* Since it's used exclusively on source pages, no need to explicitly select. * No need to hide it when the sidebar is open, since it fills the whole page.
7de1b37
to
bcf4cfe
Compare
GuillaumeGomez
approved these changes
Oct 17, 2022
Thanks! @bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#102962 (remote-test-server: Show command line arguments) - rust-lang#103129 (rustdoc: remove unused `.sub-logo-container` DOM on non-source pages) - rust-lang#103136 (Fix types in documentation for `Alignment::as_usize` and `Alignmnet::as_nonzero`) - rust-lang#103139 (Duplicate comment in mod.rs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.