Skip to content

Add size hints to early binder iterator adapters#104731

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:early-binder-iter-size-hint
Nov 26, 2022
Merged

Add size hints to early binder iterator adapters#104731
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:early-binder-iter-size-hint

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

probably doesn't do anything, but definitely doesn't hurt

@rustbot

rustbot commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@compiler-errors

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 22, 2022
@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 22, 2022
@bors

bors commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 0ba5e74 with merge bf5f92d5948ded4843a4731da0e324a5e70ff0e2...

@cjgillot

Copy link
Copy Markdown
Contributor

r=me when perf comes back.

@bors

bors commented Nov 22, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: bf5f92d5948ded4843a4731da0e324a5e70ff0e2 (bf5f92d5948ded4843a4731da0e324a5e70ff0e2)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (bf5f92d5948ded4843a4731da0e324a5e70ff0e2): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) -0.5% [-0.5%, -0.5%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-3.1%, -1.9%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 23, 2022
@compiler-errors

Copy link
Copy Markdown
Contributor Author

Probably noise, but anyways @bors r=cjgillot

@bors

bors commented Nov 23, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 0ba5e74 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2022
@bors

bors commented Nov 26, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0ba5e74 with merge c3a1c02...

@bors

bors commented Nov 26, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing c3a1c02 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 26, 2022
@bors bors merged commit c3a1c02 into rust-lang:master Nov 26, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 26, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c3a1c02): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.4% [-3.4%, -3.4%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants