Update rustdoc code blocks so they use grid: display #105894

GuillaumeGomez · 2022-12-19T10:42:50Z

It's another approach to #105823.

It generalizes the usage of display: grid for code blocks instead of just using it for scraped examples.

r? @notriddle

rustbot · 2022-12-19T10:42:57Z

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

rust-log-analyzer · 2022-12-19T11:22:06Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between 10723378900ba2d25fc5d8baf785e1082f385832 and d8d46ab217aff005b1ce7c515f82e86d75a5476e
Rustdoc was updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
.......... (90/93)
...        (93/93)


/checkout/src/test/rustdoc-gui/codeblock-tooltip.goml codeblock-tooltip... FAILED
[ERROR] (line 17 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail .tooltip`): [expected `rgb(255, 0, 0)` for key `color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail .tooltip",
            {"color": "rgb(255, 0, 0)"},
        )`
[ERROR] (line 21 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail`): [expected `2px solid rgb(255, 0, 0)` for key `border-left`, found `2px solid rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail",
            {"border-left": "2px solid rgb(255, 0, 0)"},
        )`
[ERROR] (line 25 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail .tooltip`): [expected `"This example deliberately fails to compile"` for key `content`, found `none`, expected `center` for key `text-align`, found `start`, expected `5px 3px 3px` for key `padding`, found `0px`, expected `rgb(49, 69, 89)` for key `background-color`, found `rgba(0, 0, 0, 0)`, expected `rgb(197, 197, 197)` for key `color`, found `rgba(255, 0, 0, 0.5)`, expected `1px solid rgb(92, 103, 115)` for key `border`, found `0px none rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail .tooltip::after",
            {
                "content": '"This example deliberately fails to compile"',
                "text-align": "center",
                "padding": "5px 3px 3px",
                "background-color": |background|,
                "color": |color|,
                "border": "1px solid " + |border|,
        )`
        )`
[ERROR] (line 36 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail .tooltip`): [expected `5px` for key `border-width`, found `0px`, expected `solid` for key `border-style`, found `none`, expected `rgba(0, 0, 0, 0) rgb(49, 69, 89) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)` for key `border-color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail .tooltip::before",
            {
                "border-width": "5px",
                "border-style": "solid",
                "border-color": "rgba(0, 0, 0, 0) " + |background| + " rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)",
        )`
        )`
[ERROR] (line 57 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic .tooltip`): [expected `rgb(255, 0, 0)` for key `color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic .tooltip",
            {"color": "rgb(255, 0, 0)"},
        )`
[ERROR] (line 61 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic`): [expected `2px solid rgb(255, 0, 0)` for key `border-left`, found `2px solid rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic",
            {"border-left": "2px solid rgb(255, 0, 0)"},
        )`
[ERROR] (line 65 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic .tooltip`): [expected `"This example panics"` for key `content`, found `none`, expected `center` for key `text-align`, found `start`, expected `5px 3px 3px` for key `padding`, found `0px`, expected `rgb(49, 69, 89)` for key `background-color`, found `rgba(0, 0, 0, 0)`, expected `rgb(197, 197, 197)` for key `color`, found `rgba(255, 0, 0, 0.5)`, expected `1px solid rgb(92, 103, 115)` for key `border`, found `0px none rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic .tooltip::after",
            {
                "content": '"This example panics"',
                "text-align": "center",
                "padding": "5px 3px 3px",
                "background-color": |background|,
                "color": |color|,
                "border": "1px solid " + |border|,
        )`
        )`
[ERROR] (line 76 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic .tooltip`): [expected `5px` for key `border-width`, found `0px`, expected `solid` for key `border-style`, found `none`, expected `rgba(0, 0, 0, 0) rgb(49, 69, 89) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)` for key `border-color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic .tooltip::before",
            {
                "border-width": "5px",
                "border-style": "solid",
                "border-color": "rgba(0, 0, 0, 0) " + |background| + " rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)",
        )`
        )`
[ERROR] (line 97 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore .tooltip`): [expected `rgb(255, 142, 0)` for key `color`, found `rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore .tooltip",
            {"color": "rgb(255, 142, 0)"},
        )`
[ERROR] (line 101 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore`): [expected `2px solid rgb(255, 142, 0)` for key `border-left`, found `2px solid rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore",
            {"border-left": "2px solid rgb(255, 142, 0)"},
        )`
[ERROR] (line 105 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore .tooltip`): [expected `"This example is not tested"` for key `content`, found `none`, expected `center` for key `text-align`, found `start`, expected `5px 3px 3px` for key `padding`, found `0px`, expected `rgb(49, 69, 89)` for key `background-color`, found `rgba(0, 0, 0, 0)`, expected `rgb(197, 197, 197)` for key `color`, found `rgba(255, 142, 0, 0.6)`, expected `1px solid rgb(92, 103, 115)` for key `border`, found `0px none rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore .tooltip::after",
            {
                "content": '"This example is not tested"',
                "text-align": "center",
                "padding": "5px 3px 3px",
                "background-color": |background|,
                "color": |color|,
                "border": "1px solid " + |border|,
        )`
        )`
[ERROR] (line 116 from 135) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore .tooltip`): [expected `5px` for key `border-width`, found `0px`, expected `solid` for key `border-style`, found `none`, expected `rgba(0, 0, 0, 0) rgb(49, 69, 89) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)` for key `border-color`, found `rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore .tooltip::before",
            {
                "border-width": "5px",
                "border-style": "solid",
                "border-color": "rgba(0, 0, 0, 0) " + |background| + " rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)",
        )`
        )`
[ERROR] (line 17 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail .tooltip`): [expected `rgb(255, 0, 0)` for key `color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail .tooltip",
            {"color": "rgb(255, 0, 0)"},
        )`
[ERROR] (line 21 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail`): [expected `2px solid rgb(255, 0, 0)` for key `border-left`, found `2px solid rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail",
            {"border-left": "2px solid rgb(255, 0, 0)"},
        )`
[ERROR] (line 25 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail .tooltip`): [expected `"This example deliberately fails to compile"` for key `content`, found `none`, expected `center` for key `text-align`, found `start`, expected `5px 3px 3px` for key `padding`, found `0px`, expected `rgb(0, 0, 0)` for key `background-color`, found `rgba(0, 0, 0, 0)`, expected `rgb(255, 255, 255)` for key `color`, found `rgba(255, 0, 0, 0.5)`, expected `1px solid rgb(224, 224, 224)` for key `border`, found `0px none rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail .tooltip::after",
            {
                "content": '"This example deliberately fails to compile"',
                "text-align": "center",
                "padding": "5px 3px 3px",
                "background-color": |background|,
                "color": |color|,
                "border": "1px solid " + |border|,
        )`
        )`
[ERROR] (line 36 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail .tooltip`): [expected `5px` for key `border-width`, found `0px`, expected `solid` for key `border-style`, found `none`, expected `rgba(0, 0, 0, 0) rgb(0, 0, 0) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)` for key `border-color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail .tooltip::before",
            {
                "border-width": "5px",
                "border-style": "solid",
                "border-color": "rgba(0, 0, 0, 0) " + |background| + " rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)",
        )`
        )`
[ERROR] (line 57 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic .tooltip`): [expected `rgb(255, 0, 0)` for key `color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic .tooltip",
            {"color": "rgb(255, 0, 0)"},
        )`
[ERROR] (line 61 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic`): [expected `2px solid rgb(255, 0, 0)` for key `border-left`, found `2px solid rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic",
            {"border-left": "2px solid rgb(255, 0, 0)"},
        )`
[ERROR] (line 65 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic .tooltip`): [expected `"This example panics"` for key `content`, found `none`, expected `center` for key `text-align`, found `start`, expected `5px 3px 3px` for key `padding`, found `0px`, expected `rgb(0, 0, 0)` for key `background-color`, found `rgba(0, 0, 0, 0)`, expected `rgb(255, 255, 255)` for key `color`, found `rgba(255, 0, 0, 0.5)`, expected `1px solid rgb(224, 224, 224)` for key `border`, found `0px none rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic .tooltip::after",
            {
                "content": '"This example panics"',
                "text-align": "center",
                "padding": "5px 3px 3px",
                "background-color": |background|,
                "color": |color|,
                "border": "1px solid " + |border|,
        )`
        )`
[ERROR] (line 76 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic .tooltip`): [expected `5px` for key `border-width`, found `0px`, expected `solid` for key `border-style`, found `none`, expected `rgba(0, 0, 0, 0) rgb(0, 0, 0) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)` for key `border-color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic .tooltip::before",
            {
                "border-width": "5px",
                "border-style": "solid",
                "border-color": "rgba(0, 0, 0, 0) " + |background| + " rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)",
        )`
        )`
[ERROR] (line 97 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore .tooltip`): [expected `rgb(255, 142, 0)` for key `color`, found `rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore .tooltip",
            {"color": "rgb(255, 142, 0)"},
        )`
[ERROR] (line 101 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore`): [expected `2px solid rgb(255, 142, 0)` for key `border-left`, found `2px solid rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore",
            {"border-left": "2px solid rgb(255, 142, 0)"},
        )`
[ERROR] (line 105 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore .tooltip`): [expected `"This example is not tested"` for key `content`, found `none`, expected `center` for key `text-align`, found `start`, expected `5px 3px 3px` for key `padding`, found `0px`, expected `rgb(0, 0, 0)` for key `background-color`, found `rgba(0, 0, 0, 0)`, expected `rgb(255, 255, 255)` for key `color`, found `rgba(255, 142, 0, 0.6)`, expected `1px solid rgb(224, 224, 224)` for key `border`, found `0px none rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore .tooltip::after",
            {
                "content": '"This example is not tested"',
                "text-align": "center",
                "padding": "5px 3px 3px",
                "background-color": |background|,
                "color": |color|,
                "border": "1px solid " + |border|,
        )`
        )`
[ERROR] (line 116 from 141) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore .tooltip`): [expected `5px` for key `border-width`, found `0px`, expected `solid` for key `border-style`, found `none`, expected `rgba(0, 0, 0, 0) rgb(0, 0, 0) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)` for key `border-color`, found `rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore .tooltip::before",
            {
                "border-width": "5px",
                "border-style": "solid",
                "border-color": "rgba(0, 0, 0, 0) " + |background| + " rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)",
        )`
        )`
[ERROR] (line 17 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail .tooltip`): [expected `rgb(255, 0, 0)` for key `color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail .tooltip",
            {"color": "rgb(255, 0, 0)"},
        )`
[ERROR] (line 21 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail`): [expected `2px solid rgb(255, 0, 0)` for key `border-left`, found `2px solid rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail",
            {"border-left": "2px solid rgb(255, 0, 0)"},
        )`
[ERROR] (line 25 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail .tooltip`): [expected `"This example deliberately fails to compile"` for key `content`, found `none`, expected `center` for key `text-align`, found `start`, expected `5px 3px 3px` for key `padding`, found `0px`, expected `rgb(0, 0, 0)` for key `background-color`, found `rgba(0, 0, 0, 0)`, expected `rgb(255, 255, 255)` for key `color`, found `rgba(255, 0, 0, 0.5)`, expected `1px solid rgb(224, 224, 224)` for key `border`, found `0px none rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail .tooltip::after",
            {
                "content": '"This example deliberately fails to compile"',
                "text-align": "center",
                "padding": "5px 3px 3px",
                "background-color": |background|,
                "color": |color|,
                "border": "1px solid " + |border|,
        )`
        )`
[ERROR] (line 36 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.compile_fail .tooltip`): [expected `5px` for key `border-width`, found `0px`, expected `solid` for key `border-style`, found `none`, expected `rgba(0, 0, 0, 0) rgb(0, 0, 0) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)` for key `border-color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.compile_fail .tooltip::before",
            {
                "border-width": "5px",
                "border-style": "solid",
                "border-color": "rgba(0, 0, 0, 0) " + |background| + " rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)",
        )`
        )`
[ERROR] (line 57 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic .tooltip`): [expected `rgb(255, 0, 0)` for key `color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic .tooltip",
            {"color": "rgb(255, 0, 0)"},
        )`
[ERROR] (line 61 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic`): [expected `2px solid rgb(255, 0, 0)` for key `border-left`, found `2px solid rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic",
            {"border-left": "2px solid rgb(255, 0, 0)"},
        )`
[ERROR] (line 65 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic .tooltip`): [expected `"This example panics"` for key `content`, found `none`, expected `center` for key `text-align`, found `start`, expected `5px 3px 3px` for key `padding`, found `0px`, expected `rgb(0, 0, 0)` for key `background-color`, found `rgba(0, 0, 0, 0)`, expected `rgb(255, 255, 255)` for key `color`, found `rgba(255, 0, 0, 0.5)`, expected `1px solid rgb(224, 224, 224)` for key `border`, found `0px none rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic .tooltip::after",
            {
                "content": '"This example panics"',
                "text-align": "center",
                "padding": "5px 3px 3px",
                "background-color": |background|,
                "color": |color|,
                "border": "1px solid " + |border|,
        )`
        )`
[ERROR] (line 76 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.should_panic .tooltip`): [expected `5px` for key `border-width`, found `0px`, expected `solid` for key `border-style`, found `none`, expected `rgba(0, 0, 0, 0) rgb(0, 0, 0) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)` for key `border-color`, found `rgba(255, 0, 0, 0.5)`]: for command `assert-css: (
            ".docblock .example-wrap.should_panic .tooltip::before",
            {
                "border-width": "5px",
                "border-style": "solid",
                "border-color": "rgba(0, 0, 0, 0) " + |background| + " rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)",
        )`
        )`
[ERROR] (line 97 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore .tooltip`): [expected `rgb(255, 142, 0)` for key `color`, found `rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore .tooltip",
            {"color": "rgb(255, 142, 0)"},
        )`
[ERROR] (line 101 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore`): [expected `2px solid rgb(255, 142, 0)` for key `border-left`, found `2px solid rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore",
            {"border-left": "2px solid rgb(255, 142, 0)"},
        )`
[ERROR] (line 105 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore .tooltip`): [expected `"This example is not tested"` for key `content`, found `none`, expected `center` for key `text-align`, found `start`, expected `5px 3px 3px` for key `padding`, found `0px`, expected `rgb(0, 0, 0)` for key `background-color`, found `rgba(0, 0, 0, 0)`, expected `rgb(255, 255, 255)` for key `color`, found `rgba(255, 142, 0, 0.6)`, expected `1px solid rgb(224, 224, 224)` for key `border`, found `0px none rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore .tooltip::after",
            {
                "content": '"This example is not tested"',
                "text-align": "center",
                "padding": "5px 3px 3px",
                "background-color": |background|,
                "color": |color|,
                "border": "1px solid " + |border|,
        )`
        )`
[ERROR] (line 116 from 147) Error: Evaluation failed: The following errors happened (for selector `.docblock .example-wrap.ignore .tooltip`): [expected `5px` for key `border-width`, found `0px`, expected `solid` for key `border-style`, found `none`, expected `rgba(0, 0, 0, 0) rgb(0, 0, 0) rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)` for key `border-color`, found `rgba(255, 142, 0, 0.6)`]: for command `assert-css: (
            ".docblock .example-wrap.ignore .tooltip::before",
            {
                "border-width": "5px",
                "border-style": "solid",
                "border-color": "rgba(0, 0, 0, 0) " + |background| + " rgba(0, 0, 0, 0) rgba(0, 0, 0, 0)",
        )`

Build completed unsuccessfully in 0:02:06

notriddle · 2022-12-19T13:25:22Z

src/librustdoc/html/static/css/rustdoc.css

@@ -1978,8 +1982,6 @@ in storage.js
 }

 .scraped-example .code-wrapper .example-wrap {
-	display: grid;
-	grid-template-columns: max-content auto;
 	width: 100%;
 	overflow-x: auto;


This overflow rule is redundant now, since the overflow-x is now set on all example-wrap blocks. For simplicity’s sake, overflow-y can also be lifted up to there.

notriddle · 2022-12-19T13:27:46Z

src/test/rustdoc-gui/code-blocks-overflow.goml

+assert-css: (".docblock > .example-wrap > pre", {"width": "1756px"})
+
+// Confirm that there is no change when line numbers are displayed.
+local-storage: {"rustdoc-line-numbers": "true"}


This test only works if you reload the page.

Good catch, thanks!

GuillaumeGomez · 2022-12-19T18:56:08Z

Actually this approach is very problematic because of the interactions between tooltips and display: grid. I went for another one in #105914.

…es-code-blocks, r=notriddle rustdoc: Simplify CSS for scraped code examples code blocks It's another approach than rust-lang#105894 for rust-lang#105823. I simply removed the extra style added for the scraped code blocks which appears to be unneeded. r? `@notriddle`

GuillaumeGomez added 2 commits December 19, 2022 11:41

Update rustdoc code blocks so they use grid: display

d1d0fb7

Update tests for new code blocks display rule

1db0ee1

rustbot assigned notriddle Dec 19, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 19, 2022

notriddle requested changes Dec 19, 2022

View reviewed changes

GuillaumeGomez mentioned this pull request Dec 19, 2022

rustdoc: Simplify CSS for scraped code examples code blocks #105914

Merged

GuillaumeGomez closed this Dec 19, 2022

GuillaumeGomez deleted the code-block-display-grid branch December 19, 2022 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rustdoc code blocks so they use grid: display #105894

Update rustdoc code blocks so they use grid: display #105894

GuillaumeGomez commented Dec 19, 2022

rustbot commented Dec 19, 2022

rust-log-analyzer commented Dec 19, 2022

notriddle Dec 19, 2022

notriddle Dec 19, 2022

GuillaumeGomez Dec 19, 2022

GuillaumeGomez commented Dec 19, 2022 •

edited

Loading

Update rustdoc code blocks so they use grid: display #105894

Update rustdoc code blocks so they use grid: display #105894

Conversation

GuillaumeGomez commented Dec 19, 2022

rustbot commented Dec 19, 2022

rust-log-analyzer commented Dec 19, 2022

notriddle Dec 19, 2022

Choose a reason for hiding this comment

notriddle Dec 19, 2022

Choose a reason for hiding this comment

GuillaumeGomez Dec 19, 2022

Choose a reason for hiding this comment

GuillaumeGomez commented Dec 19, 2022 • edited Loading

GuillaumeGomez commented Dec 19, 2022 •

edited

Loading