Skip to content

Fix --kbd-color variable name in rustdoc.css #106487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2023
Merged

Fix --kbd-color variable name in rustdoc.css #106487

merged 2 commits into from
Jan 5, 2023

Conversation

GuillaumeGomez
Copy link
Member

Interestingly enough, it only impacted the dark theme.

Before:

Screenshot from 2023-01-05 11-03-17

After:

Screenshot from 2023-01-05 11-03-05

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 5, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2023

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 5, 2023

📌 Commit 112723b has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2023
@bors
Copy link
Collaborator

bors commented Jan 5, 2023

⌛ Testing commit 112723b with merge 388538f...

@bors
Copy link
Collaborator

bors commented Jan 5, 2023

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 388538f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 5, 2023
@bors bors merged commit 388538f into rust-lang:master Jan 5, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 5, 2023
@GuillaumeGomez GuillaumeGomez deleted the fix-kbd-var branch January 5, 2023 18:46
@bors bors mentioned this pull request Jan 5, 2023
Merged
9 tasks
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (388538f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.5% [3.3%, 3.6%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.5% [3.3%, 3.6%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rustbot @notriddle @bors @rust-timer