-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustdoc: Strip imports of items which are #[doc(hidden)]
#106538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @notriddle (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid |
eded7e3
to
98130d1
Compare
This comment has been minimized.
This comment has been minimized.
98130d1
to
ff46d11
Compare
pub(crate) fn imported_item_is_doc_hidden(&self, tcx: TyCtxt<'_>) -> bool { | ||
match self.source.did { | ||
Some(did) => tcx | ||
.get_attrs(did, sym::doc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason that I'm not sure of, using .lists
here instead of open coding it causes panics. #106538 (comment)
I think it's to do with the difference between tcx.item_attrs
and tcx.get_attrs
, as this was the diff that fixed it.
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (93bf84c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Closes #106379