-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Simplify derive(Debug)
output for fieldless enums
#106884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
derive(Debug)
for fieldless enumsderive(Debug)
output for fieldless enums
This will get queued behind another PR but I'm quite curious |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 70091926e458fd7ddd3df29b33de3cfdb624c8dc with merge ab530986fdc49d3802aaf309560b6c5e75515da0... |
7009192
to
45143c4
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 45143c4fbec94a8323fefb0dd7a8dd5d54ede0e7 with merge 3dda7981e1a61d170870bacbe64351e30aaa3ac4... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (3dda7981e1a61d170870bacbe64351e30aaa3ac4): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Thanks for the PR, @clubby789! I'll take a closer look some time this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR, @clubby789!
It looks like the changes have the intended effect, but I think we can improve the clarity of the implementation (mostly by renaming and documenting a few things).
45143c4
to
95a824c
Compare
Thanks, @clubby789! @bors r+ |
☀️ Test successful - checks-actions |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b22aa57): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
@clubby789 Very exciting change, thank you! |
Improvements outweigh the regressions so I think it's fine if we just take this performance as is. @rustbot label: +perf-regression-triaged |
Fixes #106875