Skip to content

fix rustfmt symlink exists check in bootstrap #108316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lqd
Copy link
Member

@lqd lqd commented Feb 21, 2023

r? @ghost

(I'm trying this to see what it does on perf.rlo without reverting #107956 for now, but it's very likely needed in the general case)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 21, 2023
@lqd
Copy link
Member Author

lqd commented Feb 21, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 21, 2023
@bors
Copy link
Collaborator

bors commented Feb 21, 2023

⌛ Trying commit 6f041ec with merge a3348d9f3278a6859822a9075f39bd4e422e05cd...

@bors
Copy link
Collaborator

bors commented Feb 21, 2023

☀️ Try build successful - checks-actions
Build commit: a3348d9f3278a6859822a9075f39bd4e422e05cd (a3348d9f3278a6859822a9075f39bd4e422e05cd)

@rust-timer

This comment has been minimized.

@lqd lqd mentioned this pull request Feb 21, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a3348d9f3278a6859822a9075f39bd4e422e05cd): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.7% [4.7%, 4.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 21, 2023
@lqd
Copy link
Member Author

lqd commented Feb 22, 2023

The revert for #107834 has landed in #108302, so this PR will be only needed whenever #107834 is re-landed in some form in the future.

(It could also be unneeded if changes to rustc-perf are made on the rustc benchmark in the meantime)

@lqd lqd closed this Feb 22, 2023
@lqd lqd deleted the revert-bootstrap branch February 22, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants