Check the privacy of implemented traits #10862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| view_path_list(ref path, ref list, _) => { | ||
| for id in list.iter() { | ||
| visitor.visit_ident(id.span, id.node.name, env.clone()) | ||
| } | ||
| path | ||
| walk_path(visitor, path, 1, env.clone()); // id is ignored |
There was a problem hiding this comment.
Shouldn't visit_path/walk_path take Option<NodeId> instead?
There was a problem hiding this comment.
Oh, I see, id is ignored specifically by walk_path, not just in this instance.
This bug showed up because the visitor only visited the path of the implemented trait via walk_path (with no corresponding visit_path function). I have modified the visitor to use visit_path (which is now overridable), and the privacy visitor overrides this function and now properly checks for the privacy of all paths. Closes rust-lang#10857
bors
added a commit
that referenced
this pull request
Dec 10, 2013
This bug showed up because the visitor only visited the path of the implemented trait via walk_path (with no corresponding visit_path function). I have modified the visitor to use visit_path (which is now overridable), and the privacy visitor overrides this function and now properly checks for the privacy of all paths. Closes #10857
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
Update *Current stable* text in `CHANGELOG.md` Roses are red, violets are blue, the new version was released, and our changelog too --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug showed up because the visitor only visited the path of the implemented
trait via walk_path (with no corresponding visit_path function). I have modified
the visitor to use visit_path (which is now overridable), and the privacy
visitor overrides this function and now properly checks for the privacy of all
paths.
Closes #10857