Some rustdoc manual fixes #10913
Merged
Some rustdoc manual fixes #10913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Doc comments are markdown, and are currently parsed with the | ||
| [sundown][sundown] library. rustdoc does not yet do any fanciness such as | ||
| referencing other items inline, like javadoc's `@see`. One exception to this | ||
| is that the first sentence will be used as the "summary" of an item in the |
There was a problem hiding this comment.
Isn't the behaviour first paragraph, rather than first sentence?
|
@huonw fixed, thanks |
|
Would you mind merging in #10901 ? |
The following files need to be adjusted, too (i can't do it now): - doc/po/ja/rust.md.po - doc/po/rust.md.pot
Clarify that it's sundown, and that we don't support magic
bors
added a commit
that referenced
this pull request
Dec 13, 2013
Clarify that it's sundown, and that we don't support magic
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
[`unnecessary_to_owned`]: check that the adjusted type matches target Fixes rust-lang#10033. Before this change, the lint would assume that removing the `.to_string()` in `f(&x.to_string())` would be ok if x is of some type that implements `Deref<Target = str>` and `f` takes a `&str`. This turns out to not actually be ok if the `to_string` call is some method that exists on `x` directly, which happens if it implements `Display`/`ToString` itself. changelog: [`unnecessary_to_owned`]: only lint if the adjusted receiver type actually matches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that it's sundown, and that we don't support magic