Improve PR job names in Github Actions preview #109868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
r? infra-ci cc @RalfJung |
|
Maybe we should apply this to the auto and try sections too? e.g., https://github.com/rust-lang-ci/rust/actions/runs/4589308533/jobs/8104110343 looks like it's named similarly whereas just matrix.name is probably fine. |
Before: `CI / PR (mingw-check, false, ubuntu-20.04-16core-64gb) (pull_request)` After: `CI / PR - mingw-check (pull_request)`
|
r=me |
|
this does start showing "CI / auto - ${{ matrix.name }} (pull_request) Skipped" on PRs instead of "CI / auto (pull_request) Skipped", but given that the job is being skipped anyway, that seems ok. @bors r=Mark-Simulacrum rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 2, 2023
Improve PR job names in Github Actions preview Fixes https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/PR.20CI.20job.20names. Before: `CI / PR (mingw-check, false, ubuntu-20.04-16core-64gb) (pull_request)` After: `CI / PR - mingw-check (pull_request)` r? `@jyn514`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#109526 (LIBPATH is used as dylib's path environment variable on AIX) - rust-lang#109642 (check for missing codegen backeng config) - rust-lang#109722 (Implement read_buf for RustHermit) - rust-lang#109856 (fix(middle): emit error rather than delay bug when reaching limit) - rust-lang#109868 (Improve PR job names in Github Actions preview) - rust-lang#109871 (Include invocation start times) - rust-lang#109873 (Move some UI tests into subdirectories) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/PR.20CI.20job.20names.
Before:
CI / PR (mingw-check, false, ubuntu-20.04-16core-64gb) (pull_request)After:
CI / PR - mingw-check (pull_request)r? @jyn514