Skip to content

loongarch64-unknown-none*: Set default relocation model to static #112386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

loongarch64-unknown-none*: Set default relocation model to static #112386

merged 1 commit into from
Jun 13, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Jun 7, 2023

This PR sets the default relocation model to static for loongarch64-unknown-none* targets. This change aims to streamline the development of the bare-metal project by removing the need for the executable program loader to implement relocation.

@rustbot
Copy link
Collaborator

rustbot commented Jun 7, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 7, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 7, 2023

These commits modify compiler targets.
(See the Target Tier Policy.)

@eholk
Copy link
Contributor

eholk commented Jun 13, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 13, 2023

📌 Commit 37b465f has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2023
@bors
Copy link
Collaborator

bors commented Jun 13, 2023

⌛ Testing commit 37b465f with merge 4bd4e2e...

@bors
Copy link
Collaborator

bors commented Jun 13, 2023

☀️ Test successful - checks-actions
Approved by: eholk
Pushing 4bd4e2e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 13, 2023
@bors bors merged commit 4bd4e2e into rust-lang:master Jun 13, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 13, 2023
@heiher heiher deleted the reloc-static branch June 13, 2023 12:23
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4bd4e2e): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.0% [2.5%, 3.4%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.0% [2.5%, 3.4%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.134s -> 647.719s (-0.22%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants