Various fixes

[emberian]

See the commits for details. From my triage queue.

[huonw]

Hm, would it be possible for the SNAP printing to be split out of tidy because the current output of tidy is extremely cluttered by the NOTE: snapshot printing, to the point that even experienced rustaceans will miss things like "trailing whitespace"?

e.g. add a target check-snaps so make check runs tidy, check-snaps, etc. (This would also allow check-snaps to run git grep SNAP -- '*.rs' to filter down to just relevant lines and then process this reduced subset of lines in Python, which will be much faster than iterating over the entirety of each file in Python, and so probably won't be much slower than only doing one pass (as is currently implemented).)

[emberian]

I'm not sure if we can use git grep, since we need to be able to make check
outside of the repo (tarballs).

On Tue, Dec 31, 2013 at 7:52 PM, Huon Wilson [email protected]:

Hm, would it be possible for the SNAP printing to be split out of tidybecause the current output of
tidy is extremely cluttered by the NOTE: snapshot printing, to the point
that even experienced rustaceans will miss things like "trailing
whitespace"?

e.g. add a target check-snaps so make check runs tidy, check-snaps, etc.
(This would also allow check-snaps to run git grep SNAP -- '*.rs' to
filter down to just relevant lines, which will be much faster than
iterating over each file in Python, and so probably won't be much slower.)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11250#issuecomment-31416430
.

[emberian]

r? @huonw, @alexcrichton, @brson

I made tidy stop spitting out every NOTE line, unless it contains "snap". It really isn't useful. This might be a contentious change?

[alexcrichton]

I think I commented on this commit as well, but let's leave this out for now.