Skip to content

Stabilize chown functions (unix_chown) #113033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2023
Merged

Stabilize chown functions (unix_chown) #113033

merged 1 commit into from
Jul 22, 2023

Conversation

JohnTitor
Copy link
Member

Closes #88989
FCP is complete here: #88989 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 25, 2023
@cuviper
Copy link
Member

cuviper commented Jul 21, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 21, 2023

📌 Commit f95be95 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2023
@bors
Copy link
Collaborator

bors commented Jul 22, 2023

⌛ Testing commit f95be95 with merge e0922fb...

@bors
Copy link
Collaborator

bors commented Jul 22, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing e0922fb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 22, 2023
@bors bors merged commit e0922fb into rust-lang:master Jul 22, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 22, 2023
@JohnTitor JohnTitor deleted the stabilize-unix-chown branch July 22, 2023 09:37
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e0922fb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.6s -> 652.988s (0.06%)

@joshtriplett joshtriplett added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for #![feature(unix_chown)]
6 participants
@JohnTitor @rustbot @cuviper @bors @rust-timer @joshtriplett