Skip to content

Remove another DefiningAnchor::Bubble usage #113294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove another DefiningAnchor::Bubble usage #113294

wants to merge 2 commits into from

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 3, 2023

This doesn't affect anything, but removes one difference between the new and the old solver.

r? @lcnr

cc #113278

@oli-obk oli-obk changed the title Remove another DefiningAnchor::Bubble user Remove another DefiningAnchor::Bubble usage Jul 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

Those failing tests were the ones I was talking about -- we could bump the logic in compiler/rustc_lint/src/opaque_hidden_inferred_bound.rs to be a hard error for TAITs in order to keep those tests failing.

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 4, 2023

oof... yea, at least all the cases are now hard errors, instead of just some 😆

@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
lcnr
lcnr reviewed Jul 4, 2023
View reviewed changes
compiler/rustc_lint/src/opaque_hidden_inferred_bound.rs
);
}
hir::OpaqueTyOrigin::TyAlias { .. } => {
cx.tcx.sess.emit_err(OpaqueHiddenInferredBoundErr {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard errors in rustc_lint is somewhat :/

I also don't think we should error (or even lint, for that matter) here, tho

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened a zulip thread about this https://rust-lang.zulipchat.com/#narrow/stream/315482-t-compiler.2Fetc.2Fopaque-types/topic/nested.20opaque.20bounds

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a technical perspective, yeah, we shouldn't be doing hard errors inside of the lint infrastructure I think.

@bors
Copy link
Collaborator

bors commented Jul 6, 2023

☔ The latest upstream changes (presumably #113377) made this pull request unmergeable. Please resolve the merge conflicts.

@lcnr lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2023
@oli-obk
Copy link
Contributor Author

oli-obk commented Oct 25, 2023

This has become obsolete.

@oli-obk oli-obk closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rustbot @rust-log-analyzer @compiler-errors @bors @lcnr