Don't ICE in resolve_bound_vars when associated return-type bounds are in bad positions
#113426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
fee1-dead
approved these changes
Jul 6, 2023
Comment on lines
341
to
342
| // though this may happen when we call `poly_trait_ref_binder_info` with | ||
| // an (erroneous) associated return type bound in an impl header. |
There was a problem hiding this comment.
Link to the issue or the ui test
rust-cloud-vms
bot
force-pushed
the
rtn-in-impl-header
branch
from
21f3a13 to
2990e31
Compare
…e in bad positions
rust-cloud-vms
bot
force-pushed
the
rtn-in-impl-header
branch
from
2990e31 to
b7191d8
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 8, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#113413 (Add needs-triage to all new issues) - rust-lang#113426 (Don't ICE in `resolve_bound_vars` when associated return-type bounds are in bad positions) - rust-lang#113427 (Remove `variances_of` on RPITIT GATs, remove its one use-case) - rust-lang#113441 (miri: check that assignments do not self-overlap) - rust-lang#113453 (Remove unused from_method from rustc_on_unimplemented) - rust-lang#113456 (Avoid calling report_forbidden_specialization for RPITITs) - rust-lang#113466 (Update cargo) - rust-lang#113467 (Fix comment of `fn_can_unwind`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find a better way to avoid hitting this ICE, so let's just delay it.
The problem is that we really shouldn't even be trying to visit associated type bounds in
resolve_bound_varswhen they show up in impl headers, but we don't have enough context to do this.Fixes #113423