Skip to content

Add ty convs for smir refs and ptrs #113659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2023
Merged

Add ty convs for smir refs and ptrs #113659

merged 3 commits into from
Jul 18, 2023

Conversation

ericmarkmartin
Copy link
Contributor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 13, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 13, 2023

☔ The latest upstream changes (presumably #113673) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@spastorino
Copy link
Member

This looks good, please rebase.

@ericmarkmartin ericmarkmartin marked this pull request as ready for review July 15, 2023 03:52
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ericmarkmartin
Copy link
Contributor Author

@spastorino I rebased but CI seems to be unhappy

@spastorino
Copy link
Member

@ericmarkmartin I'm not sure what happened, it seems that Mark force pushed into master. I'd say, try rebasing again now because as I'm seeing this PR is not correctly rebased on top of the current master. Likely that force push.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@spastorino
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

📌 Commit c8ee46b has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2023
@matthiaskrgr
Rollup merge of rust-lang#113659 - ericmarkmartin:smir-refs-and-ptrs,…
cac0665 
… r=spastorino

Add ty convs for smir refs and ptrs

r? `@spastorino`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 18, 2023
Closed
@bors
Copy link
Collaborator

bors commented Jul 18, 2023

⌛ Testing commit c8ee46b with merge 0f16bd3...

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing 0f16bd3 to master...

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing 0f16bd3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 18, 2023
@bors bors merged commit 0f16bd3 into rust-lang:master Jul 18, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 18, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0f16bd3): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.7% [0.6%, 0.8%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.0% [-3.0%, -3.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.3% [2.3%, 2.3%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 658.29s -> 658.53s (0.04%)

@ericmarkmartin ericmarkmartin deleted the smir-refs-and-ptrs branch July 20, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ericmarkmartin @rust-log-analyzer @bors @spastorino @rustbot @rust-timer