Skip to content

Properly document lifetime_mapping in OpaqueTy #113795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

Properly document lifetime_mapping in OpaqueTy #113795

merged 1 commit into from
Jul 20, 2023

Conversation

compiler-errors
Copy link
Member

Also use an Option to signify that the value is actually present, instead of just no captured lifetimes.

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@compiler-errors
Copy link
Member Author

r? spastorino

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 17, 2023
@rustbot rustbot assigned spastorino and unassigned davidtwco Jul 17, 2023
@spastorino
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 17, 2023

📌 Commit 603fd42 has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 18, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2023
@matthiaskrgr
Rollup merge of rust-lang#113795 - compiler-errors:doc, r=spastorino
0ac5851 
Properly document `lifetime_mapping` in `OpaqueTy`

Also use an `Option` to signify that the value is actually present, instead of just no captured lifetimes.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2023
@matthiaskrgr
Rollup merge of rust-lang#113795 - compiler-errors:doc, r=spastorino
b3893c5 
Properly document `lifetime_mapping` in `OpaqueTy`

Also use an `Option` to signify that the value is actually present, instead of just no captured lifetimes.
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 18, 2023
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 18, 2023
@GuillaumeGomez
Rollup merge of rust-lang#113795 - compiler-errors:doc, r=spastorino
c4b3011 
Properly document `lifetime_mapping` in `OpaqueTy`

Also use an `Option` to signify that the value is actually present, instead of just no captured lifetimes.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 18, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2023
@matthiaskrgr
Rollup merge of rust-lang#113795 - compiler-errors:doc, r=spastorino
05e42ed 
Properly document `lifetime_mapping` in `OpaqueTy`

Also use an `Option` to signify that the value is actually present, instead of just no captured lifetimes.
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 18, 2023
Closed
@bors
Copy link
Collaborator

bors commented Jul 18, 2023

⌛ Testing commit 603fd42 with merge f3bed8d4a12ae036eac438cc4f5ce35da7c76767...

@bors
Copy link
Collaborator

bors commented Jul 18, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2023
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@compiler-errors
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 20, 2023
@bors
Auto merge of rust-lang#113878 - matthiaskrgr:rollup-u0d3kzx, r=matth…
c67cb3e 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#113710 (Fix rpath for libdir is specified)
 - rust-lang#113787 (Update documentation for std::process::Command's new method)
 - rust-lang#113795 (Properly document `lifetime_mapping` in `OpaqueTy`)
 - rust-lang#113857 (Add tests for `--document-hidden-items` option)
 - rust-lang#113871 (Use the correct span for displaying the line following a derive sugge…)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b128750 into rust-lang:master Jul 20, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 20, 2023
@compiler-errors compiler-errors deleted the doc branch August 11, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rustbot @spastorino @bors @rust-log-analyzer @davidtwco