rust-installer: Use env(1) in the shebang.

[inferiorhumanorgans]

This fixes the case (e.g. *BSD) where bash is installed on the host system, but not at the typical location of /bin.

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ozkanonur (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[onur-ozkan]

Thank you!

[onur-ozkan]

@bors r+ rollup

[bors]

📌 Commit 302ad21 has been approved by ozkanonur

It is now in the queue for this repository.

[onur-ozkan]

believe that other scripts in rust-analyzer should also use env to find bash path

@bors r-
@rustbot author

[inferiorhumanorgans]

believe that other scripts in rust-analyzer should also use env to find bash path

For the rest of the installer scripts I think there's a good case to be made for switching them over, however I'm not in a great position to test them.

I've run ./x dist successfully without modification on a machine that doesn't have /bin/bash (or at least I think I did…), but am pretty green at building rust and currently focused on cross compiling a native toolchain from a machine that has /bin/bash.

[onur-ozkan]

however I'm not in a great position to test them.

Sure 👍

I will take a look on those later then. Thanks for the PR!

@bors r+

[bors]

📌 Commit 302ad21 has been approved by ozkanonur

It is now in the queue for this repository.

[bors]

⌛ Testing commit 302ad21 with merge bccefd2...

[bors]

☀️ Test successful - checks-actions
Approved by: ozkanonur
Pushing bccefd2 to master...

[rust-timer]

Finished benchmarking commit (bccefd2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 651.225s -> 652.153s (0.14%)