Skip to content

Detect missing ; that parses as function call #114474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Aug 4, 2023

Fix #106515.

@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2023
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it too permissive to suggest this on any expr kind? Why is this still limited to just Path | Call | Lit?

@estebank
Copy link
Contributor Author

estebank commented Aug 8, 2023

Is it too permissive to suggest this on any expr kind?

I was slightly concerned, but you're right: this could happen with any expression. I gated this behind the "array element missing comma" check as otherwise [(foo,) (bar,), (baz,)] would get both "missing comma" and "missing semicolon" suggestions.

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 10, 2023

📌 Commit 8ecb486 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 10, 2023
…errors

Detect missing `;` that parses as function call

Fix rust-lang#106515.
@bors
Copy link
Collaborator

bors commented Aug 10, 2023

⌛ Testing commit 8ecb486 with merge 5b0c4d2f62a046287e4035dfe1073efaa2b31784...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-apple-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
 81  558M   81  457M    0     0  21.6M      0  0:00:25  0:00:21  0:00:04 26.2M
 89  558M   89  500M    0     0  22.5M      0  0:00:24  0:00:22  0:00:02 27.3M
 96  558M   96  537M    0     0  23.2M      0  0:00:24  0:00:23  0:00:01 28.4M
100  558M  100  558M    0     0  23.4M      0  0:00:23  0:00:23 --:--:-- 34.2M
xcrun: error: unable to locate xcodebuild, please make sure the path to the Xcode folder is set correctly!
xcrun: error: You can set the path to the Xcode folder using /usr/bin/xcode-select -switch
src/ci/scripts/install-wix.sh
shell: /bin/bash --noprofile --norc -e -o pipefail {0}
---
configure: 
configure: run `python /Users/runner/work/rust/rust/x.py --help`
##[endgroup]
Attempting with retry: make prepare
make: error: unable to locate xcodebuild, please make sure the path to the Xcode folder is set correctly!
make: error: You can set the path to the Xcode folder using /usr/bin/xcode-select -switch
Command failed. Attempt 2/5:
make: error: unable to locate xcodebuild, please make sure the path to the Xcode folder is set correctly!
make: error: You can set the path to the Xcode folder using /usr/bin/xcode-select -switch
Command failed. Attempt 3/5:
make: error: unable to locate xcodebuild, please make sure the path to the Xcode folder is set correctly!
make: error: You can set the path to the Xcode folder using /usr/bin/xcode-select -switch
Command failed. Attempt 4/5:
make: error: unable to locate xcodebuild, please make sure the path to the Xcode folder is set correctly!
make: error: You can set the path to the Xcode folder using /usr/bin/xcode-select -switch
Command failed. Attempt 5/5:
make: error: unable to locate xcodebuild, please make sure the path to the Xcode folder is set correctly!
make: error: You can set the path to the Xcode folder using /usr/bin/xcode-select -switch
  local time: Thu Aug 10 07:53:19 UTC 2023
  network time: Thu, 10 Aug 2023 07:53:23 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Collaborator

bors commented Aug 10, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 10, 2023
@estebank
Copy link
Contributor Author

seems spurious
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2023
@bors
Copy link
Collaborator

bors commented Aug 10, 2023

⌛ Testing commit 8ecb486 with merge 439d066...

@bors
Copy link
Collaborator

bors commented Aug 10, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 439d066 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 10, 2023
@bors bors merged commit 439d066 into rust-lang:master Aug 10, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 10, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (439d066): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.409s -> 632.053s (-0.06%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected "expected function" error with unit type
7 participants