-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Detect missing ;
that parses as function call
#114474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it too permissive to suggest this on any expr kind? Why is this still limited to just Path | Call | Lit
?
I was slightly concerned, but you're right: this could happen with any expression. I gated this behind the "array element missing comma" check as otherwise |
@bors r+ |
…errors Detect missing `;` that parses as function call Fix rust-lang#106515.
⌛ Testing commit 8ecb486 with merge 5b0c4d2f62a046287e4035dfe1073efaa2b31784... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
seems spurious |
☀️ Test successful - checks-actions |
Finished benchmarking commit (439d066): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.409s -> 632.053s (-0.06%) |
Fix #106515.