Skip to content

update Miri #114735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 11, 2023
Merged

update Miri #114735

merged 20 commits into from
Aug 11, 2023

Conversation

RalfJung
Copy link
Member

r? @ghost

RalfJung and others added 20 commits August 6, 2023 22:44
rustc-pull: put a newline after the commit ID
This avoids unnecessary allocations to grow vector to sufficient size.
[perf] Reserve capacity for argvs.

This avoids unnecessary allocations to grow vector to sufficient size.
Use Vec's binary search instead of hand-written one.
replace AsAny hack by trait upcasting :)
Implements LLVM intrisics needed to run most SSE functions from `core::arch::x86{,_64}`.

Also adds miri tests for those functions (mostly copied from core_arch tests).
add gamma function shims

needs a rustup to fetch the new declarations in std
miri: implement some `llvm.x86.sse.*` intrinsics and add tests

PR moved from rust-lang#113932.

Implements LLVM intrisics needed to run most SSE functions from `core::arch::x86{,_64}`.

Also adds miri tests for those functions (mostly copied from core_arch tests).

r? `@RalfJung`

The first commit is the same that the commit in the PR I had opened in the Rust repository. I addressed review comments in additional commits to make it easier to review. I also fixed formatting and clippy warnings.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 11, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2023

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Aug 11, 2023

📌 Commit a45f181 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 11, 2023
@bors
Copy link
Collaborator

bors commented Aug 11, 2023

⌛ Testing commit a45f181 with merge a6f8aa5...

@bors
Copy link
Collaborator

bors commented Aug 11, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing a6f8aa5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 11, 2023
@bors bors merged commit a6f8aa5 into rust-lang:master Aug 11, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 11, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a6f8aa5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.671s -> 631.476s (-0.03%)

@RalfJung RalfJung deleted the miri branch August 15, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants