-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Include compiler flags when you break rust;
#115158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To make it available to other parts of the compiler.
This comment has been minimized.
This comment has been minimized.
Looks like you'll have to normalize the exact flags away for the test. This LGTM, but I'm not at all familiar with that code. |
4cea5b0
to
d5e79f2
Compare
r? compiler-errors @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (a8b905c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 633.115s -> 632.601s (-0.08%) |
Closes #70661
r? @RalfJung who requested this feature :)