Skip to content

Conversation

@RalfJung
Copy link
Member

r? @ghost

RalfJung and others added 26 commits August 22, 2023 14:45
fix some bad regex capture group references in test normalization
tests/catch_panic: make output easier to interpret
add tests for track_caller in closures and generators

taken from rust-lang#87064
make sure we test all tier 1 targets

i686-pc-windows-gnu was missing (and i686-pc-windows-msvc was being tested twice, as host and foreign target).
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 31, 2023

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Aug 31, 2023

📌 Commit 873a7a3 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2023
@bors
Copy link
Collaborator

bors commented Aug 31, 2023

⌛ Testing commit 873a7a3 with merge b30b535...

@bors
Copy link
Collaborator

bors commented Aug 31, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing b30b535 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 31, 2023
@bors bors merged commit b30b535 into rust-lang:master Aug 31, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 31, 2023
@RalfJung RalfJung deleted the miri branch August 31, 2023 18:02
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b30b535): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [0.8%, 1.3%] 3
Regressions ❌
(secondary)
2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.5% [-0.5%, 1.3%] 5

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.374s -> 631.748s (0.06%)
Artifact size: 316.55 MiB -> 316.58 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants