Skip to content

update Miri #115496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 3, 2023
Merged

update Miri #115496

merged 11 commits into from
Sep 3, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 3, 2023

There were conflicts on the last pull, so make sure it's all in sync both ways

r? @ghost

RalfJung and others added 11 commits August 31, 2023 16:56
@RalfJung
update target support section
3e66914
@RalfJung
don't ignore sign for ABI check
fd92d95
@bors
Auto merge of rust-lang#3047 - RalfJung:target-support, r=saethlin
a346b29 
update target support section

The MIPS targets were demoted to tier 3, so let's recommend a different big-endian target.

Also instead of listing the targets we test individually, just say we test all tier 1 targets.

r? `@rust-lang/miri`
@RalfJung
add '--skip-children' to rustfmt invocation
f28772f
@bors
Auto merge of rust-lang#3048 - RalfJung:fmt-skip-children, r=RalfJung
cae8f93 
add '--skip-children' to rustfmt invocation

This finally fixes the issue that we format the same file many times (and `./miri fmt --check` shows duplicate diffs). :)
@RalfJung
Preparing for merge from rustc
d2923a4
@RalfJung
Merge from rustc
97ee830
@bors
Auto merge of rust-lang#3049 - RalfJung:rustup, r=RalfJung
d2f5dc9 
Rustup
@RalfJung
Preparing for merge from rustc
dc81d6c
@RalfJung
Merge from rustc
fb26c21
@bors
Auto merge of rust-lang#3050 - RalfJung:rustup, r=RalfJung
f2568c8 
Rustup
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2023

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

RalfJung commented Sep 3, 2023

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

📌 Commit f2568c8 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2023
@bors
Copy link
Collaborator

bors commented Sep 3, 2023

⌛ Testing commit f2568c8 with merge b89d7d6...

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing b89d7d6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2023
@bors bors merged commit b89d7d6 into rust-lang:master Sep 3, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 3, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b89d7d6): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.3% [0.2%, 0.4%] 4
Regressions ❌
(secondary)		 0.5% [0.3%, 0.6%] 5
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.3% [0.2%, 0.4%] 4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.112s -> 630.051s (-0.01%)
Artifact size: 316.75 MiB -> 316.64 MiB (-0.04%)

@rustbot rustbot added the perf-regression Performance regression. label Sep 3, 2023
@RalfJung
Copy link
Member Author

RalfJung commented Sep 4, 2023

This has to be spurious.

@saethlin
Copy link
Member

saethlin commented Sep 4, 2023

I agree.

@RalfJung RalfJung deleted the miri branch September 5, 2023 06:13
@pnkfelix
Copy link
Member

pnkfelix commented Sep 5, 2023

believe to be spurious, marking as triaged

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rustbot @bors @rust-timer @saethlin @pnkfelix