Skip to content

[DO NOT MERGE] Experimentally force non-leaf frame pointers #115521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

[DO NOT MERGE] Experimentally force non-leaf frame pointers #115521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions compiler/rustc_codegen_llvm/src/attributes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,9 @@
}
let attr_value = match fp {
FramePointer::Always => "all",
FramePointer::NonLeaf => "non-leaf",
FramePointer::MayOmit => return None,
// TODO: a real impl instead of a shitty one-off hack

Check failure on line 116 in compiler/rustc_codegen_llvm/src/attributes.rs

View workflow job for this annotation

GitHub Actions / PR - mingw-check-tidy 

TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
FramePointer::NonLeaf | FramePointer::MayOmit => "non-leaf",
// FramePointer::MayOmit => return None,
};
Some(llvm::CreateAttrStringValue(cx.llcx, "frame-pointer", attr_value))
}
Expand Down
Loading