-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add function that returns span of an item in smir #115703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino |
Yea, I wanna change Span to be able to add methods on it that query data from TyCtxt. This PR is orthogonal to that tho @bors r+ |
Add function that returns span of an item in smir Addressees rust-lang/project-stable-mir#31 Maybe we should change `Span = Opaque` into something else, and then return `String` with newly added function, I don't think it matters that much though, since we are not storing `Span` anywhere. r? `@oli-obk`
☀️ Test successful - checks-actions |
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
Finished benchmarking commit (c1b38c7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 628.91s -> 629.541s (0.10%) |
@bors retry |
☀️ Test successful - checks-actions |
Finished benchmarking commit (8ed4537): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 628.555s -> 627.878s (-0.11%) |
Addressees rust-lang/project-stable-mir#31
Maybe we should change
Span = Opaque
into something else, and then returnString
with newly added function, I don't think it matters that much though, since we are not storingSpan
anywhere.r? @oli-obk