Rename Invert to Flip - Issue #10632 #11686
Conversation
|
We should discuss this before merging as it doesn't look like there was consensus on the issue of what course of action to take. |
|
I'm okay with renaming this. I don't really care much either way but I think |
|
I just commented on the issue, I was thinking maybe it should be That is if people aren't happy with |
|
+1 for |
|
I, too, think that It doesn't sound like there's much opposition to these names, so would you mind rebasing with the new names? |
|
Not a problem. :) |
Renamed the invert() function in iter.rs to flip(). Also renamed the Invert<T> type to Flip<T>. Some related code comments changed. Documentation that I could find has been updated, and all the instances I could locate where the function/type were called have been updated as well.
Consensus leaned in favour of using rev instead of flip.
…632, r=alexcrichton Renamed the ```invert()``` function in ```iter.rs``` to ```flip()```, from #10632 Also renamed the ```Invert<T>``` type to ```Flip<T>```. Some related code comments changed. Documentation that I could find has been updated, and all the instances I could locate where the function/type were called have been updated as well. This is my first contribution to Rust! Apologies in advance if I've snarfed the PR process, I'm not used to rebase. I initially had issues with the ```codegen``` section of the tests failing, however the ```make check``` process is not reporting any failures at this time. I think that was a local env issue more than me facerolling my changes. :)
…entri3 Lint `flatten()` under `lines_filter_map_ok` Fixes rust-lang#11686 changelog: [`lines_filter_map_ok`]: Also lint calls to `flatten()`
Renamed the
invert()function initer.rstoflip(), from #10632Also renamed the
Invert<T>type toFlip<T>.Some related code comments changed. Documentation that I could find has
been updated, and all the instances I could locate where the
function/type were called have been updated as well.
This is my first contribution to Rust! Apologies in advance if I've snarfed the
PR process, I'm not used to rebase.
I initially had issues with the
codegensection of the tests failing, howeverthe
make checkprocess is not reporting any failures at this time. I thinkthat was a local env issue more than me facerolling my changes. :)