Feature gate #[simd] #11738
Merged
Feature gate #[simd] #11738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub struct i64x2(i64, i64); //~ ERROR: SIMD types are experimental | ||
|
|
||
| fn main() { | ||
| let _ = simd::i64x2(0, 0); //~ ERROR: experimental |
There was a problem hiding this comment.
Have you run this test past make check yet? I think that the feature gating happens at a much earlier phase than the stability lint checking levels. You may just need to split this into two tests.
|
This looks great, thanks! |
|
Will this actually prevent people from using simd? Doesn't this just make |
|
@brson: we could mark those as |
|
They are marked experimental by this PR. |
|
Sounds good. |
|
Unfortunately it looks like we don't handle cross-crate tuple structs correctly, so this currently doesn't stop people using |
bors
added a commit
that referenced
this pull request
Jan 28, 2014
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 18, 2024
Removed the `from_expansion` guard clause for cast lints, so that these warnings can be generated for internal macros.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 18, 2024
Allow `cast` lints in macros closes: rust-lang#11738 Removed the `from_expansion` guard clause for cast lints, so that these warnings can be generated for internal macros. changelog: allow `cast` lints in macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11721