Skip to content

Feature gate #[simd] #11738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2014
Merged

Feature gate #[simd] #11738

merged 1 commit into from
Jan 28, 2014

Conversation

@dmanescu
Copy link
Contributor

@dmanescu dmanescu commented Jan 23, 2014

Fixes #11721

alexcrichton
alexcrichton reviewed Jan 23, 2014
View reviewed changes
src/test/compile-fail/gated-simd.rs Outdated
Copy link
Member

@alexcrichton alexcrichton Jan 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run this test past make check yet? I think that the feature gating happens at a much earlier phase than the stability lint checking levels. You may just need to split this into two tests.

@alexcrichton
Copy link
Member

alexcrichton commented Jan 23, 2014

This looks great, thanks!

@brson
Copy link
Contributor

brson commented Jan 23, 2014

Will this actually prevent people from using simd? Doesn't this just make std declare that it's implementing the simd types without preventing people from using them?

@thestinger
Copy link
Contributor

thestinger commented Jan 23, 2014

@brson: we could mark those as #[experimental]

@huonw
Copy link
Contributor

huonw commented Jan 23, 2014

They are marked experimental by this PR.

@brson
Copy link
Contributor

brson commented Jan 23, 2014

Sounds good.

@huonw
Copy link
Contributor

huonw commented Jan 23, 2014

Unfortunately it looks like we don't handle cross-crate tuple structs correctly, so this currently doesn't stop people using std::unstable::simd, but when #11741 is fixed it will.

bors added a commit that referenced this pull request Jan 28, 2014
@bors
auto merge of #11738 : dmanescu/rust/11721, r=alexcrichton
1ac9bf6 
Fixes #11721
@bors bors closed this Jan 28, 2014
@bors bors merged commit 28b987b into rust-lang:master Jan 28, 2014
@dmanescu dmanescu mentioned this pull request Jan 30, 2014
Merged
bors added a commit that referenced this pull request Feb 1, 2014
@bors
auto merge of #11932 : dmanescu/rust/11741-stability-cross-crate, r=a…
362cbbe 
…lexcrichton

Fixes #11741
Added tests and removed xfail-fast from run-pass/simd-experimental which is now fixed (see #11738).
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 18, 2024
@franciscoBSalgueiro
Fix rust-lang#11738: allow cast lints in macros
ac225a3 
Removed the `from_expansion` guard clause for cast lints, so that these warnings can be generated for internal macros.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 18, 2024
@bors
Auto merge of rust-lang#12631 - franciscoBSalgueiro:11738, r=blyxyas
08dac85 
Allow `cast` lints in macros

closes: rust-lang#11738

Removed the `from_expansion` guard clause for cast lints, so that these warnings can be generated for internal macros.

changelog: allow `cast` lints in macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RFC: feature gate #[simd] & mark the simd types in std #[experimental]

6 participants

@dmanescu @alexcrichton @brson @thestinger @huonw @bors