[WIP] const-stabilize Hash{Map/Set}::new

[aDotInTheVoid]

Extremely normal, nothing to see here.

r? @ghost

[aDotInTheVoid]

@bors try

[bors]

⌛ Trying commit 15605a9 with merge 4a3d002...

[rust-log-analyzer]

The job x86_64-gnu-llvm-16 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=rust-cloud-vms[bot]
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_4dc955b4-e016-4db7-b356-d0a76e79f648
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=3f6cd1e9451c1724fec384dce07290218c8b0236
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_4dc955b4-e016-4db7-b356-d0a76e79f648
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_4dc955b4-e016-4db7-b356-d0a76e79f648
GITHUB_TRIGGERING_ACTOR=rust-cloud-vms[bot]
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/118416/merge
GITHUB_WORKFLOW_SHA=3f6cd1e9451c1724fec384dce07290218c8b0236
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_19_X64=/opt/hostedtoolcache/go/1.19.13/x64
---
........................................................................................  3256/15852
........................................................................................  3344/15852
........................................................................................  3432/15852
........................................................................................  3520/15852
......................FF.F..............................................................  3608/15852
........................................................................................  3784/15852
.........................i.........................................i....................  3872/15852
........................................................................................  3960/15852
........................................................................................  4048/15852
---
---- [ui] tests/ui/borrowck/issue-64453.rs stdout ----
diff of stderr:

3    |
4 LL | static settings_dir: String = format!("");
+   --> $SRC_DIR/core/src/fmt/mod.rs:LL:COL
+    |
+    = note: `Arguments::<'a>::new_const` declared unstable here
6    |
---
To only update this specific test, also pass `--test-args borrowck/issue-64453.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/borrowck/issue-64453.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/issue-64453" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/borrowck/issue-64453/auxiliary"
--- stderr -------------------------------
error: `Arguments::<'a>::new_const` is not yet stable as a const fn
##[error]  --> /checkout/tests/ui/borrowck/issue-64453.rs:4:31
   |
   |
LL | static settings_dir: String = format!("");
  --> /rustc/FAKE_PREFIX/library/core/src/fmt/mod.rs:321:5
   |
   = note: `Arguments::<'a>::new_const` declared unstable here
   |
   |
   = help: add `#![feature(const_fmt_arguments_new)]` to the crate attributes to enable
   = note: this error originates in the macro `$crate::__export::format_args` which comes from the expansion of the macro `format` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0015]: cannot call non-const fn `format` in statics
##[error]  --> /checkout/tests/ui/borrowck/issue-64453.rs:4:31
   |
LL | static settings_dir: String = format!("");
   |
   = note: calls in statics are limited to constant functions, tuple structs and tuple variants
   = note: calls in statics are limited to constant functions, tuple structs and tuple variants
   = note: consider wrapping this expression in `Lazy::new(|| ...)` from the `once_cell` crate: https://crates.io/crates/once_cell
   = note: this error originates in the macro `format` (in Nightly builds, run with -Z macro-backtrace for more info)


error[E0507]: cannot move out of static item `settings_dir`
   |
   |
LL |     let settings_data = from_string(settings_dir);
   |                                     ^^^^^^^^^^^^ move occurs because `settings_dir` has type `String`, which does not implement the `Copy` trait
error: aborting due to 3 previous errors

Some errors have detailed explanations: E0015, E0507.
For more information about an error, try `rustc --explain E0015`.
---

1 error: `foo` is not yet stable as a const fn
2   --> $DIR/dont_promote_unstable_const_fn.rs:14:25
3    |
+ LL | const fn foo() -> u32 { 42 }
+    | --------------------- `foo` declared unstable here
4 LL | const fn bar() -> u32 { foo() }
5    |                         ^^^^^
6    |

---
   |
LL | const fn foo() -> u32 { 42 }
   | --------------------- `foo` declared unstable here
...
LL | const fn bar() -> u32 { foo() } //~ ERROR `foo` is not yet stable as a const fn
   |
   |
   = help: add `#![feature(foo)]` to the crate attributes to enable
error[E0716]: temporary value dropped while borrowed
##[error]  --> /checkout/tests/ui/consts/const-eval/dont_promote_unstable_const_fn.rs:17:28
   |
   |
LL |     let _: &'static u32 = &foo(); //~ ERROR temporary value dropped while borrowed
   |            ------------    ^^^^^ creates a temporary value which is freed while still in use
   |            |
   |            type annotation requires that borrow lasts for `'static`
   | - temporary value is freed at the end of this statement

error[E0716]: temporary value dropped while borrowed
##[error]  --> /checkout/tests/ui/consts/const-eval/dont_promote_unstable_const_fn.rs:21:28
##[error]  --> /checkout/tests/ui/consts/const-eval/dont_promote_unstable_const_fn.rs:21:28
   |
LL |     let _: &'static u32 = &meh(); //~ ERROR temporary value dropped while borrowed
   |            ------------    ^^^^^ creates a temporary value which is freed while still in use
   |            |
   |            type annotation requires that borrow lasts for `'static`
LL | }
   | - temporary value is freed at the end of this statement

error[E0716]: temporary value dropped while borrowed
error[E0716]: temporary value dropped while borrowed
##[error]  --> /checkout/tests/ui/consts/const-eval/dont_promote_unstable_const_fn.rs:22:26
   |
LL |     let x: &'static _ = &std::time::Duration::from_millis(42).subsec_millis();
   |            ----------    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use
   |            |
   |            type annotation requires that borrow lasts for `'static`
LL |     //~^ ERROR temporary value dropped while borrowed
   | - temporary value is freed at the end of this statement

error: aborting due to 4 previous errors

---

1 error: `foo` is not yet stable as a const fn
2   --> $DIR/min_const_fn_libstd_stability.rs:16:25
3    |
+ LL | const fn foo() -> u32 { 42 }
+    | --------------------- `foo` declared unstable here
4 LL | const fn bar() -> u32 { foo() }
5    |                         ^^^^^
6    |


9 error: `foo2` is not yet stable as a const fn
10   --> $DIR/min_const_fn_libstd_stability.rs:24:26
11    |
+ LL | const fn foo2() -> u32 { 42 }
+    | ---------------------- `foo2` declared unstable here
12 LL | const fn bar2() -> u32 { foo2() }
13    |                          ^^^^^^
14    |


34 error: `foo2_gated` is not yet stable as a const fn
35   --> $DIR/min_const_fn_libstd_stability.rs:39:32
36    |
+ LL | const fn foo2_gated() -> u32 { 42 }
+    | ---------------------------- `foo2_gated` declared unstable here
+ ...
37 LL | const fn bar2_gated() -> u32 { foo2_gated() }
39    |


The actual stderr differed from the expected stderr.
---
   |
LL | const fn foo() -> u32 { 42 }
   | --------------------- `foo` declared unstable here
...
LL | const fn bar() -> u32 { foo() } //~ ERROR not yet stable as a const fn
   |
   = help: const-stable functions can only call other const-stable functions

error: `foo2` is not yet stable as a const fn
error: `foo2` is not yet stable as a const fn
##[error]  --> /checkout/tests/ui/consts/min_const_fn/min_const_fn_libstd_stability.rs:24:26
   |
LL | const fn foo2() -> u32 { 42 }
   | ---------------------- `foo2` declared unstable here
...
LL | const fn bar2() -> u32 { foo2() } //~ ERROR not yet stable as a const fn
   |
   = help: const-stable functions can only call other const-stable functions


error: const-stable function cannot use `#[feature(const_fn_floating_point_arithmetic)]`
   |
   |
LL | const fn bar3() -> u32 { (5f32 + 6f32) as u32 }
   |
   |
help: if it is not part of the public API, make this function unstably const
   |
LL + #[rustc_const_unstable(feature = "...", issue = "...")]
LL | const fn bar3() -> u32 { (5f32 + 6f32) as u32 }
   |
help: otherwise `#[rustc_allow_const_fn_unstable]` can be used to bypass stability checks
   |
LL + #[rustc_allow_const_fn_unstable(const_fn_floating_point_arithmetic)]
LL | const fn bar3() -> u32 { (5f32 + 6f32) as u32 }

error: `foo2_gated` is not yet stable as a const fn
##[error]  --> /checkout/tests/ui/consts/min_const_fn/min_const_fn_libstd_stability.rs:39:32
   |
   |
LL | const fn foo2_gated() -> u32 { 42 }
   | ---------------------------- `foo2_gated` declared unstable here
...
LL | const fn bar2_gated() -> u32 { foo2_gated() } //~ ERROR not yet stable as a const fn
   |
   = help: const-stable functions can only call other const-stable functions

error: aborting due to 4 previous errors
---

1 error: `foo` is not yet stable as a const fn
2   --> $DIR/min_const_unsafe_fn_libstd_stability.rs:16:41
3    |
+ LL | const unsafe fn foo() -> u32 { 42 }
+    | ---------------------------- `foo` declared unstable here
+ ...
4 LL | const unsafe fn bar() -> u32 { unsafe { foo() } }
6    |

9 error: `foo2` is not yet stable as a const fn
10   --> $DIR/min_const_unsafe_fn_libstd_stability.rs:24:42
10   --> $DIR/min_const_unsafe_fn_libstd_stability.rs:24:42
11    |
+ LL | const unsafe fn foo2() -> u32 { 42 }
+    | ----------------------------- `foo2` declared unstable here
+ ...
12 LL | const unsafe fn bar2() -> u32 { unsafe { foo2() } }
14    |

34 error: `foo2_gated` is not yet stable as a const fn
35   --> $DIR/min_const_unsafe_fn_libstd_stability.rs:39:48
35   --> $DIR/min_const_unsafe_fn_libstd_stability.rs:39:48
36    |
+ LL | const unsafe fn foo2_gated() -> u32 { 42 }
+    | ----------------------------------- `foo2_gated` declared unstable here
+ ...
37 LL | const unsafe fn bar2_gated() -> u32 { unsafe { foo2_gated() } }
39    |


The actual stderr differed from the expected stderr.
---
   |
LL | const unsafe fn foo() -> u32 { 42 }
   | ---------------------------- `foo` declared unstable here
...
LL | const unsafe fn bar() -> u32 { unsafe { foo() } } //~ ERROR not yet stable as a const fn
   |
   = help: const-stable functions can only call other const-stable functions

error: `foo2` is not yet stable as a const fn
error: `foo2` is not yet stable as a const fn
##[error]  --> /checkout/tests/ui/consts/min_const_fn/min_const_unsafe_fn_libstd_stability.rs:24:42
   |
LL | const unsafe fn foo2() -> u32 { 42 }
   | ----------------------------- `foo2` declared unstable here
...
LL | const unsafe fn bar2() -> u32 { unsafe { foo2() } } //~ ERROR not yet stable as a const fn
   |
   = help: const-stable functions can only call other const-stable functions


error: const-stable function cannot use `#[feature(const_fn_floating_point_arithmetic)]`
   |
   |
LL | const unsafe fn bar3() -> u32 { (5f32 + 6f32) as u32 }
   |
   |
help: if it is not part of the public API, make this function unstably const
   |
LL + #[rustc_const_unstable(feature = "...", issue = "...")]
LL | const unsafe fn bar3() -> u32 { (5f32 + 6f32) as u32 }
   |
help: otherwise `#[rustc_allow_const_fn_unstable]` can be used to bypass stability checks
   |
LL + #[rustc_allow_const_fn_unstable(const_fn_floating_point_arithmetic)]
LL | const unsafe fn bar3() -> u32 { (5f32 + 6f32) as u32 }

error: `foo2_gated` is not yet stable as a const fn
##[error]  --> /checkout/tests/ui/consts/min_const_fn/min_const_unsafe_fn_libstd_stability.rs:39:48
   |
   |
LL | const unsafe fn foo2_gated() -> u32 { 42 }
   | ----------------------------------- `foo2_gated` declared unstable here
...
LL | const unsafe fn bar2_gated() -> u32 { unsafe { foo2_gated() } }
   |
   = help: const-stable functions can only call other const-stable functions

error: aborting due to 4 previous errors
---

1 error: `foo` is not yet stable as a const fn
2   --> $DIR/min_const_unsafe_fn_libstd_stability2.rs:16:32
3    |
+ LL | const fn foo() -> u32 { 42 }
+    | --------------------- `foo` declared unstable here
4 LL | const unsafe fn bar() -> u32 { foo() }
5    |                                ^^^^^
6    |


9 error: `foo2` is not yet stable as a const fn
10   --> $DIR/min_const_unsafe_fn_libstd_stability2.rs:24:33
11    |
+ LL | const fn foo2() -> u32 { 42 }
+    | ---------------------- `foo2` declared unstable here
12 LL | const unsafe fn bar2() -> u32 { foo2() }
13    |                                 ^^^^^^
14    |


17 error: `foo2_gated` is not yet stable as a const fn
18   --> $DIR/min_const_unsafe_fn_libstd_stability2.rs:33:39
19    |
+ LL | const fn foo2_gated() -> u32 { 42 }
+    | ---------------------------- `foo2_gated` declared unstable here
+ ...
20 LL | const unsafe fn bar2_gated() -> u32 { foo2_gated() }
22    |


The actual stderr differed from the expected stderr.
---
   |
LL | const fn foo() -> u32 { 42 }
   | --------------------- `foo` declared unstable here
...
LL | const unsafe fn bar() -> u32 { foo() } //~ ERROR not yet stable as a const fn
   |
   = help: const-stable functions can only call other const-stable functions

error: `foo2` is not yet stable as a const fn
error: `foo2` is not yet stable as a const fn
##[error]  --> /checkout/tests/ui/consts/min_const_fn/min_const_unsafe_fn_libstd_stability2.rs:24:33
   |
LL | const fn foo2() -> u32 { 42 }
   | ---------------------- `foo2` declared unstable here
...
LL | const unsafe fn bar2() -> u32 { foo2() } //~ ERROR not yet stable as a const fn
   |
   = help: const-stable functions can only call other const-stable functions

error: `foo2_gated` is not yet stable as a const fn
error: `foo2_gated` is not yet stable as a const fn
##[error]  --> /checkout/tests/ui/consts/min_const_fn/min_const_unsafe_fn_libstd_stability2.rs:33:39
   |
LL | const fn foo2_gated() -> u32 { 42 }
   | ---------------------------- `foo2_gated` declared unstable here
...
LL | const unsafe fn bar2_gated() -> u32 { foo2_gated() } //~ ERROR not yet stable as a const fn
   |
   = help: const-stable functions can only call other const-stable functions

error: aborting due to 3 previous errors
---

1 error: `const_eval_select` is not yet stable as a const fn
2   --> $DIR/const-eval-select-stability.rs:17:5
3    |
- LL |     const_eval_select((), nothing, log);
-    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+ LL |       const_eval_select((), nothing, log);
+   --> $SRC_DIR/core/src/intrinsics.rs:LL:COL
+   ::: $SRC_DIR/core/src/intrinsics.rs:LL:COL
+    |
+    = note: `const_eval_select` declared unstable here
---
--- stderr -------------------------------
error: `const_eval_select` is not yet stable as a const fn
##[error]  --> /checkout/tests/ui/intrinsics/const-eval-select-stability.rs:17:5
   |
LL |       const_eval_select((), nothing, log);
  --> /rustc/FAKE_PREFIX/library/core/src/intrinsics.rs:2482:5
  ::: /rustc/FAKE_PREFIX/library/core/src/intrinsics.rs:2486:12
   |
   = note: `const_eval_select` declared unstable here
---

---- [ui] tests/ui/rfcs/rfc-2632-const-trait-impl/staged-api.rs#unstable stdout ----
diff of stderr:

1 error: `<Foo as staged_api::MyTrait>::func` is not yet stable as a const fn
3    |
+ LL |     fn func() {}
+ LL |     fn func() {}
+    |     --------- `<Foo as staged_api::MyTrait>::func` declared unstable here
4 LL |     Foo::func();
5    |     ^^^^^^^^^^^
6    |


9 error: `<Foo as staged_api::MyTrait>::func` is not yet stable as a const fn
11    |
+ LL |     fn func() {}
+ LL |     fn func() {}
+    |     --------- `<Foo as staged_api::MyTrait>::func` declared unstable here
12 LL |     Foo::func();
13    |     ^^^^^^^^^^^
14    |


20 LL |     Unstable::func();
21    |     ^^^^^^^^^^^^^^^^
22    |
+   ::: $DIR/auxiliary/staged-api.rs:18:5
+    |
+ LL |     fn func() {}
+    |     --------- `<staged_api::Unstable as staged_api::MyTrait>::func` declared unstable here
23    = help: const-stable functions can only call other const-stable functions
24 
24 
25 error: `<Foo as staged_api::MyTrait>::func` is not yet stable as a const fn
26   --> $DIR/staged-api.rs:57:5
27    |
+ LL |     fn func() {}
+ LL |     fn func() {}
+    |     --------- `<Foo as staged_api::MyTrait>::func` declared unstable here
28 LL |     Foo::func();
29    |     ^^^^^^^^^^^
30    |

---
38    |


The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfcs/rfc-2632-const-trait-impl/staged-api.unstable/staged-api.unstable.stderr
To only update this specific test, also pass `--test-args rfcs/rfc-2632-const-trait-impl/staged-api.rs`


error in revision `unstable`: 1 errors occurred comparing output.
status: exit status: 1
command: RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/rfcs/rfc-2632-const-trait-impl/staged-api.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--cfg" "unstable" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfcs/rfc-2632-const-trait-impl/staged-api.unstable" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfcs/rfc-2632-const-trait-impl/staged-api.unstable/auxiliary"
--- stderr -------------------------------
--- stderr -------------------------------
error: `<Foo as staged_api::MyTrait>::func` is not yet stable as a const fn
   |
LL |     fn func() {}
LL |     fn func() {}
   |     --------- `<Foo as staged_api::MyTrait>::func` declared unstable here
LL |     Foo::func();
   |     ^^^^^^^^^^^
   |
   |
   = help: add `#![feature(foo)]` to the crate attributes to enable

error: `<Foo as staged_api::MyTrait>::func` is not yet stable as a const fn
   |
LL |     fn func() {}
LL |     fn func() {}
   |     --------- `<Foo as staged_api::MyTrait>::func` declared unstable here
LL |     Foo::func();
   |     ^^^^^^^^^^^
   |
   |
   = help: add `#![feature(foo)]` to the crate attributes to enable

error: `<staged_api::Unstable as staged_api::MyTrait>::func` is not yet stable as a const fn
   |
LL |     Unstable::func();
   |     ^^^^^^^^^^^^^^^^
   |
   |
  ::: /checkout/tests/ui/rfcs/rfc-2632-const-trait-impl/auxiliary/staged-api.rs:18:5
   |
LL |     fn func() {}
   |     --------- `<staged_api::Unstable as staged_api::MyTrait>::func` declared unstable here
   = help: const-stable functions can only call other const-stable functions


error: `<Foo as staged_api::MyTrait>::func` is not yet stable as a const fn
   |
LL |     fn func() {}
LL |     fn func() {}
   |     --------- `<Foo as staged_api::MyTrait>::func` declared unstable here
LL |     Foo::func();
   |     ^^^^^^^^^^^
   |
   = help: const-stable functions can only call other const-stable functions
---
5    |     ^^^^^^^^
6    |
+   ::: $DIR/auxiliary/const-stability-attribute-implies.rs:12:1
+    |
+ LL | pub const fn foobar() {}
+    | --------------------- `foobar` declared unstable here
+    |
7    = help: add `#![feature(const_foobar)]` to the crate attributes to enable
9 error: aborting due to 1 previous error


The actual stderr differed from the expected stderr.
---
--- stderr -------------------------------
error: `foobar` is not yet stable as a const fn
##[error]  --> /checkout/tests/ui/stability-attribute/const-stability-attribute-implies-no-feature.rs:12:5
   |
LL |     foobar(); //~ ERROR `foobar` is not yet stable as a const fn
   |
  ::: /checkout/tests/ui/stability-attribute/auxiliary/const-stability-attribute-implies.rs:12:1
   |
LL | pub const fn foobar() {}
LL | pub const fn foobar() {}
   | --------------------- `foobar` declared unstable here
   |
   = help: add `#![feature(const_foobar)]` to the crate attributes to enable
error: aborting due to 1 previous error
------------------------------------------